Collate stacks in test output

Collate stacks in test output

Usage:

$ tools/test.py -m release \
       -c dart2js -r d8 --dart2js-batch --report \
       --host-checked \
       --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/ --use-kernel" \
       language corelib library_2 corelib_2 \
       dart2js_native dart2js_extra \
  2>&1 > LOG

$ dart pkg/compiler/tool/status_files/stacks.dart LOG > STACKS.txt

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/559718806770270117a50dbdac64ef7f7560b557

[sra1, 2017-08-09 17:59:52]

sra@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-09 18:08:02]

lgtm

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
File pkg/compiler/tool/status_files/log_parser.dart (right):

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
pkg/compiler/tool/status_files/log_parser.dart:22: var paragraph = []; //
collector forlines
forlines? for fullReason?

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
File pkg/compiler/tool/status_files/stacks.dart (right):

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
pkg/compiler/tool/status_files/stacks.dart:65: final map = {};
Map<String, TrieNode> ?

[Siggi Cherem (dart-lang), 2017-08-09 18:09:06]

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
File pkg/compiler/tool/status_files/stacks.dart (right):

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
pkg/compiler/tool/status_files/stacks.dart:5: // $ dart stacks.dart LOG >
STACK.txt
consider renaming to include a verb that indicates what the script does? for
example:
  rank_stacks.dart
  show_top_stacks.dart
?

[sra1, 2017-08-09 20:15:13]

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
File pkg/compiler/tool/status_files/log_parser.dart (right):

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
pkg/compiler/tool/status_files/log_parser.dart:22: var paragraph = []; //
collector forlines
On 2017/08/09 18:08:02, Siggi Cherem (dart-lang) wrote:
> forlines? for fullReason?

Done.

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
File pkg/compiler/tool/status_files/stacks.dart (right):

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
pkg/compiler/tool/status_files/stacks.dart:5: // $ dart stacks.dart LOG >
STACK.txt
On 2017/08/09 18:09:06, Siggi Cherem (dart-lang) wrote:
> consider renaming to include a verb that indicates what the script does? for
> example:
>   rank_stacks.dart
>   show_top_stacks.dart
> ?

Done.

https://codereview.chromium.org/2999753002/diff/1/pkg/compiler/tool/status_fi...
pkg/compiler/tool/status_files/stacks.dart:65: final map = {};
On 2017/08/09 18:08:02, Siggi Cherem (dart-lang) wrote:
> Map<String, TrieNode> ?

Done.

[sra1, 2017-08-09 20:46:34]

Description was changed from

==========
Collate stacks in test output

Usage:

$ tools/test.py -m release \
       -c dart2js -r d8 --dart2js-batch --report \
       --host-checked \
       --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/ --use-kernel"
\
       language corelib library_2 corelib_2 \
       dart2js_native dart2js_extra \
  2>&1 > LOG

$ dart pkg/compiler/tool/status_files/stacks.dart LOG > STACKS.txt
==========

to

==========
Collate stacks in test output

Usage:

$ tools/test.py -m release \
       -c dart2js -r d8 --dart2js-batch --report \
       --host-checked \
       --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/ --use-kernel"
\
       language corelib library_2 corelib_2 \
       dart2js_native dart2js_extra \
  2>&1 > LOG

$ dart pkg/compiler/tool/status_files/stacks.dart LOG > STACKS.txt

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/559718806770270117a50dbdac64ef7f7560b557
==========

[sra1, 2017-08-09 20:46:35]

Committed patchset #3 (id:40001) manually as
559718806770270117a50dbdac64ef7f7560b557 (presubmit successful).