Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: runtime/vm/symbols.cc

Issue 2999743002: [vm] Reset vm isolate symbol table load factor (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/symbols.cc
diff --git a/runtime/vm/symbols.cc b/runtime/vm/symbols.cc
index f4e0df36b38294fb95707fb136fe4b485317eae7..668c4984a4d7e79af4b29f5d74805450032580f7 100644
--- a/runtime/vm/symbols.cc
+++ b/runtime/vm/symbols.cc
@@ -336,9 +336,11 @@ RawArray* Symbols::UnifiedSymbolTable() {
}
table.Release();
- const double kMinLoad = 0.90;
- const double kMaxLoad = 0.90;
- HashTables::EnsureLoadFactor(kMinLoad, kMaxLoad, unified_table);
+ // TODO(30378): The default load factor of 0.75 / 2 burns ~100KB, but
+ // increasing the load factor regresses Flutter's hot restart time.
+ // const double kMinLoad = 0.90;
+ // const double kMaxLoad = 0.90;
+ // HashTables::EnsureLoadFactor(kMinLoad, kMaxLoad, unified_table);
return unified_table.Release().raw();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698