Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tests/language_2/checked_setter2_test.dart

Issue 2999733002: Migrate test block 47 and downstream dependencies to Dart 2.0. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language_2/checked_setter2_test.dart
diff --git a/tests/language_strong/checked_setter2_test.dart b/tests/language_2/checked_setter2_test.dart
similarity index 55%
rename from tests/language_strong/checked_setter2_test.dart
rename to tests/language_2/checked_setter2_test.dart
index 970d505b282c0e4bb070ba1e8af707a0abe0c756..9a8098aa0cc6371ca059479cbda2917b6d2f4068 100644
--- a/tests/language_strong/checked_setter2_test.dart
+++ b/tests/language_2/checked_setter2_test.dart
@@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// Test that implicit setters in checked mode do a type check generic types.
+// Test that implicit setters do a type check generic types.
import "package:expect/expect.dart";
@@ -18,14 +18,5 @@ var array = [new B()];
main() {
array[0].c = new C();
- bool inCheckedMode = false;
- try {
- var i = 42;
- String a = i;
- } catch (e) {
- inCheckedMode = true;
- }
- if (inCheckedMode) {
- Expect.throws(() => array[0].c = new C<bool>(), (e) => e is TypeError);
- }
+ Expect.throws(() => array[0].c = /*@compile-error=unspecified*/new C<bool>(), (e) => e is TypeError);
bkonyi 2017/08/09 16:23:03 Do we need this Expect.throws(...) if this line is
jcollins 2017/08/15 14:55:15 Done.
}

Powered by Google App Engine
This is Rietveld 408576698