Migrate test block 47 and downstream dependencies to Dart 2.0.

Migrate test block 47 and downstream dependencies to Dart 2.0.

Special items in this block:
- checked_mode_helper is a helper library that needed extensive modifications.  Fixing it up for Dart 2.0 meant simultaneously migrating
its users in blocks 113 and 163.  Renamed it to dynamic_type_helper to try to reflect what it's actually doing now.
- Many minor breakouts of compile-time errors and conversion from static warnings.
BUG=
R=bkonyi@google.com

Committed: https://github.com/dart-lang/sdk/commit/52ba74db8fddc85b3d823baae08f9d800df29015

[jcollins, 2017-08-09 15:20:29]

Description was changed from

==========
Migrate test block 47 and downstream dependencies to Dart 2.0.

BUG=
==========

to

==========
Migrate test block 47 and downstream dependencies to Dart 2.0.

Special items in this block:
- checked_mode_helper is a helper library that needed extensive modifications. 
Fixing it up for Dart 2.0 meant simultaneously migrating
its users in blocks 113 and 163.  Renamed it to dynamic_type_helper to try to
reflect what it's actually doing now.
- Many minor breakouts of compile-time errors and conversion from static
warnings.
BUG=
==========

[jcollins, 2017-08-09 15:20:29]

jcollins@google.com changed reviewers:
+ bkonyi@google.com

[bkonyi, 2017-08-09 16:23:03]

LGTM after Expect.throws(...) comments are addressed. If a line with
Expect.throws(...) now causes errors at compile time, that makes the check
useless right? I could be mistaken though :)

https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
File tests/language_2/checked_setter2_test.dart (right):

https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
tests/language_2/checked_setter2_test.dart:21: Expect.throws(() => array[0].c =
/*@compile-error=unspecified*/new C<bool>(), (e) => e is TypeError);
Do we need this Expect.throws(...) if this line is going to cause static errors?

https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
File tests/language_2/checked_setter3_test.dart (right):

https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
tests/language_2/checked_setter3_test.dart:24: Expect.throws(() => a.field = i,
(e) => e is TypeError); //# 03: compile-time error
Same as the last comment. I'm pretty sure we can do away with Expect.throws(...)
for these sort of changes, right?

[jcollins, 2017-08-15 14:55:15]

https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
File tests/language_2/checked_setter2_test.dart (right):

https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
tests/language_2/checked_setter2_test.dart:21: Expect.throws(() => array[0].c =
/*@compile-error=unspecified*/new C<bool>(), (e) => e is TypeError);
On 2017/08/09 16:23:03, bkonyi wrote:
> Do we need this Expect.throws(...) if this line is going to cause static
errors?

Done.

https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
File tests/language_2/checked_setter3_test.dart (right):

https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
tests/language_2/checked_setter3_test.dart:24: Expect.throws(() => a.field = i,
(e) => e is TypeError); //# 03: compile-time error
On 2017/08/09 16:23:03, bkonyi wrote:
> Same as the last comment. I'm pretty sure we can do away with
Expect.throws(...)
> for these sort of changes, right?

Done.

[jcollins, 2017-08-16 16:00:39]

On 2017/08/15 14:55:15, jcollins wrote:
>
https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
> File tests/language_2/checked_setter2_test.dart (right):
> 
>
https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
> tests/language_2/checked_setter2_test.dart:21: Expect.throws(() => array[0].c
=
> /*@compile-error=unspecified*/new C<bool>(), (e) => e is TypeError);
> On 2017/08/09 16:23:03, bkonyi wrote:
> > Do we need this Expect.throws(...) if this line is going to cause static
> errors?
> 
> Done.
> 
>
https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
> File tests/language_2/checked_setter3_test.dart (right):
> 
>
https://codereview.chromium.org/2999733002/diff/1/tests/language_2/checked_se...
> tests/language_2/checked_setter3_test.dart:24: Expect.throws(() => a.field =
i,
> (e) => e is TypeError); //# 03: compile-time error
> On 2017/08/09 16:23:03, bkonyi wrote:
> > Same as the last comment. I'm pretty sure we can do away with
> Expect.throws(...)
> > for these sort of changes, right?
> 
> Done.

PTAL, two more tests (checked_setter_test and class_literal_test) needed changes
after recent
runtime/compiler changes.

[jcollins, 2017-08-16 16:17:06]

jcollins@google.com changed reviewers:
+ rnystrom@google.com

[bkonyi, 2017-08-16 17:14:40]

LGTM after Expect.throws(...) in class_literal_test are removed.

https://codereview.chromium.org/2999733002/diff/40001/tests/language_2/class_...
File tests/language_2/class_literal_test.dart (right):

https://codereview.chromium.org/2999733002/diff/40001/tests/language_2/class_...
tests/language_2/class_literal_test.dart:26: Expect.throws(() { Class(); }, (e)
=> e is NoSuchMethodError); //# 01: compile-time error
You can remove all the Expect.throws(...) here.

[jcollins, 2017-08-16 18:23:20]

Description was changed from

==========
Migrate test block 47 and downstream dependencies to Dart 2.0.

Special items in this block:
- checked_mode_helper is a helper library that needed extensive modifications. 
Fixing it up for Dart 2.0 meant simultaneously migrating
its users in blocks 113 and 163.  Renamed it to dynamic_type_helper to try to
reflect what it's actually doing now.
- Many minor breakouts of compile-time errors and conversion from static
warnings.
BUG=
==========

to

==========
Migrate test block 47 and downstream dependencies to Dart 2.0.

Special items in this block:
- checked_mode_helper is a helper library that needed extensive modifications. 
Fixing it up for Dart 2.0 meant simultaneously migrating
its users in blocks 113 and 163.  Renamed it to dynamic_type_helper to try to
reflect what it's actually doing now.
- Many minor breakouts of compile-time errors and conversion from static
warnings.
BUG=
R=bkonyi@google.com

Committed:
https://github.com/dart-lang/sdk/commit/52ba74db8fddc85b3d823baae08f9d800df29015
==========

[jcollins, 2017-08-16 18:23:21]

Committed patchset #5 (id:80001) manually as
52ba74db8fddc85b3d823baae08f9d800df29015.

[jcollins, 2017-08-16 18:26:54]

On 2017/08/16 18:23:21, jcollins wrote:
> Committed patchset #5 (id:80001) manually as
> 52ba74db8fddc85b3d823baae08f9d800df29015.

As discussed offline, removing Expect.throws and/or the anonymous functions
seems to alter the pass/fail behavior of the VM vs. the tests.  Leaving them in
with a TODO explaining the situation until someone with knowledge of the VM can
examine this more closely.

Janice

[sra1, 2017-08-16 22:59:34]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-08-16 22:59:36]

https://codereview.chromium.org/2999733002/diff/80001/tests/zzz
File tests/zzz (right):

https://codereview.chromium.org/2999733002/diff/80001/tests/zzz#newcode1
tests/zzz:1: 192 ./corelib[_strong]/apply2_test.dart
What is this file?

[bkonyi, 2017-08-17 00:38:05]

https://codereview.chromium.org/2999733002/diff/80001/tests/zzz
File tests/zzz (right):

https://codereview.chromium.org/2999733002/diff/80001/tests/zzz#newcode1
tests/zzz:1: 192 ./corelib[_strong]/apply2_test.dart
On 2017/08/16 22:59:36, sra1 wrote:
> What is this file?

I think this is some output generated by the script that created the migration
blocks. It should probably be removed.