Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2999723002: Add stub versions of KernelInferrerEngine and friends (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add stub versions of KernelInferrerEngine and friends + use BackendStrategy to select inference engine. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4d47a0c2de54202cab03afb3001bfe10f3833634

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -149 lines) Patch
M pkg/compiler/lib/src/backend_strategy.dart View 1 2 chunks +5 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/inferrer/kernel_inferrer_engine.dart View 1 1 chunk +149 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 5 chunks +50 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 1 3 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 1 3 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 8 chunks +135 lines, -81 lines 0 comments Download
M tests/compiler/dart2js/closure_tracer_28919_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/closure_tracer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/issue13354_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/list_tracer_typed_data_length_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/map_tracer_const_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/map_tracer_keys_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/map_tracer_test.dart View 2 chunks +11 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_and_or_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_callers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_closure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_const_closure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_try_catch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/trust_type_annotations_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_inference6_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference7_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_inference8_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_inference_switch_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-09 13:29:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2999723002/diff/1/pkg/compiler/lib/src/backend_strategy.dart File pkg/compiler/lib/src/backend_strategy.dart (right): https://codereview.chromium.org/2999723002/diff/1/pkg/compiler/lib/src/backend_strategy.dart#newcode56 pkg/compiler/lib/src/backend_strategy.dart:56: GlobalTypeInferenceResults createTypesInferrerResults( does this need to be in ...
3 years, 4 months ago (2017-08-09 16:22:43 UTC) #3
Johnni Winther
https://codereview.chromium.org/2999723002/diff/1/pkg/compiler/lib/src/backend_strategy.dart File pkg/compiler/lib/src/backend_strategy.dart (right): https://codereview.chromium.org/2999723002/diff/1/pkg/compiler/lib/src/backend_strategy.dart#newcode56 pkg/compiler/lib/src/backend_strategy.dart:56: GlobalTypeInferenceResults createTypesInferrerResults( On 2017/08/09 16:22:42, Siggi Cherem (dart-lang) wrote: ...
3 years, 4 months ago (2017-08-10 09:00:50 UTC) #4
Johnni Winther
3 years, 4 months ago (2017-08-10 10:02:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4d47a0c2de54202cab03afb3001bfe10f3833634 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698