Implement support for property accessors

Implement support for property accessors

 - Evaluation of PropertyGet expression by accessing a field,
 execution of a getter or creating a method tearoff.
 - Evaluation of PropertySet expression by setting a field or
 execution of a setter.

BUG=
R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/3cac905c541be065bc037fb30dabb1abe07d2165

[zhivkag, 2017-08-09 07:08:58]

zhivkag@google.com changed reviewers:
+ dmitryas@google.com, kmillikin@google.com

[Dmitry Stefantsov, 2017-08-16 08:48:56]

LGTM if you respond to the comments below.

https://codereview.chromium.org/2999673002/diff/1/pkg/kernel/lib/interpreter/...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2999673002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:1087: assert(methodName.toString()
== "call");
Maybe it's better to throw an exception here using the recently added exception
machinery?  At least, we may write a TODO for it now :)

https://codereview.chromium.org/2999673002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:1749: // todo: throw NoSuchInstance
error instead.
todo ==> TODO

[zhivkag, 2017-08-16 09:39:49]

Thanks!

https://codereview.chromium.org/2999673002/diff/1/pkg/kernel/lib/interpreter/...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2999673002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:1087: assert(methodName.toString()
== "call");
On 2017/08/16 08:48:55, Dmitry Stefantsov wrote:
> Maybe it's better to throw an exception here using the recently added
exception
> machinery?  At least, we may write a TODO for it now :)

Added a TODO.

https://codereview.chromium.org/2999673002/diff/1/pkg/kernel/lib/interpreter/...
pkg/kernel/lib/interpreter/interpreter.dart:1749: // todo: throw NoSuchInstance
error instead.
On 2017/08/16 08:48:55, Dmitry Stefantsov wrote:
> todo ==> TODO

Done.

[zhivkag, 2017-08-21 06:38:55]

Description was changed from

==========
Implement support for property accessors

 - Evaluation of PropertyGet expression by accessing a field,
 execution of a getter or creating a method tearoff.
 - Evaluation of PropertySet expression by setting a field or
 execution of a setter.

BUG=
==========

to

==========
Implement support for property accessors

 - Evaluation of PropertyGet expression by accessing a field,
 execution of a getter or creating a method tearoff.
 - Evaluation of PropertySet expression by setting a field or
 execution of a setter.

BUG=
R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3cac905c541be065bc037fb30dabb1abe07d2165
==========

[zhivkag, 2017-08-21 06:38:57]

Committed patchset #3 (id:40001) manually as
3cac905c541be065bc037fb30dabb1abe07d2165 (presubmit successful).