Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/engine/non_blocking_sync_common.h

Issue 299963002: sync: Implement NonBlockingTypeProcessorCore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Small comment fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/model_thread_sync_entity.cc ('k') | sync/engine/non_blocking_sync_common.cc » ('j') | sync/engine/non_blocking_sync_common.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/non_blocking_sync_common.h
diff --git a/sync/engine/non_blocking_sync_common.h b/sync/engine/non_blocking_sync_common.h
index f07fdb2684e2c2239bc9f838456e06242bd8234f..5848dc6e4692ab2fc4ced681b5830a2b2517be7c 100644
--- a/sync/engine/non_blocking_sync_common.h
+++ b/sync/engine/non_blocking_sync_common.h
@@ -14,6 +14,8 @@
namespace syncer {
+static const int64 kUncommittedVersion = -1;
+
// Data-type global state that must be accessed and updated on the sync thread,
// but persisted on or through the model thread.
struct SYNC_EXPORT_PRIVATE DataTypeState {
@@ -43,6 +45,11 @@ struct SYNC_EXPORT_PRIVATE DataTypeState {
// client-tagged data types supported by non-blocking sync, but we will
// continue to emulate the directory sync's behavior for now.
int64 next_client_id;
+
+ // This flag is set to true when the first download cycle is complete. The
+ // model thread should not attempt to commit any items until this flag is
Nicolas Zea 2014/06/02 20:27:17 nit: prefer referring to NonBlockingTypeProcessor
rlarocque 2014/06/02 21:39:14 Done.
+ // set.
+ bool initial_sync_done;
};
struct SYNC_EXPORT_PRIVATE CommitRequestData {
« no previous file with comments | « sync/engine/model_thread_sync_entity.cc ('k') | sync/engine/non_blocking_sync_common.cc » ('j') | sync/engine/non_blocking_sync_common.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698