Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2999623002: Improve compare-failures output for multiple [BuildUri] results (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve compare-failures output for multiple [BuildUri] results R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/803ec54d1c10e343fcea598224037dcc14e51475

Patch Set 1 #

Patch Set 2 : Fix test #

Total comments: 2

Patch Set 3 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -79 lines) Patch
M tools/gardening/lib/src/compare_failures_impl.dart View 1 2 3 chunks +128 lines, -78 lines 0 comments Download
M tools/gardening/test/compare_failures_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-08 10:02:15 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/2999623002/diff/20001/tools/gardening/lib/src/compare_failures_impl.dart File tools/gardening/lib/src/compare_failures_impl.dart (right): https://codereview.chromium.org/2999623002/diff/20001/tools/gardening/lib/src/compare_failures_impl.dart#newcode72 tools/gardening/lib/src/compare_failures_impl.dart:72: sb.write('No errors found for build bot:\n'); I would ...
3 years, 4 months ago (2017-08-08 13:42:03 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as 803ec54d1c10e343fcea598224037dcc14e51475 (presubmit successful).
3 years, 4 months ago (2017-08-08 14:23:23 UTC) #5
Johnni Winther
3 years, 4 months ago (2017-08-08 14:23:30 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2999623002/diff/20001/tools/gardening/lib/src...
File tools/gardening/lib/src/compare_failures_impl.dart (right):

https://codereview.chromium.org/2999623002/diff/20001/tools/gardening/lib/src...
tools/gardening/lib/src/compare_failures_impl.dart:72: sb.write('No errors found
for build bot:\n');
On 2017/08/08 13:42:02, floitsch wrote:
> I would use "writeln"
> 
> here and in the other places that have a string that ends with "\n".

Done.

Powered by Google App Engine
This is Rietveld 408576698