Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2999583002: Renames the isolate's mutator_thread_ to scheduled_mutator_thread_ (Closed)

Created:
3 years, 4 months ago by danunez
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Renames the isolate's mutator_thread_ to scheduled_mutator_thread_ The isolate's mutator_thread_ field actually represents the mutator thread scheduled by the isolate. This was confused with the mutator thread created by the thread_registry, which is a singleton. R=asiva@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/38aba431110c37000253846a2d9fdd7a778f02c5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M runtime/vm/base_isolate.h View 1 chunk +2 lines, -2 lines 1 comment Download
M runtime/vm/isolate.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/isolate.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danunez
3 years, 4 months ago (2017-08-07 22:17:02 UTC) #1
rmacnak
lgtm https://codereview.chromium.org/2999583002/diff/1/runtime/vm/base_isolate.h File runtime/vm/base_isolate.h (right): https://codereview.chromium.org/2999583002/diff/1/runtime/vm/base_isolate.h#newcode20 runtime/vm/base_isolate.h:20: // constructor/destructor for performance. Wow, this comment is ...
3 years, 4 months ago (2017-08-07 22:44:07 UTC) #2
danunez
3 years, 4 months ago (2017-08-07 22:54:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38aba431110c37000253846a2d9fdd7a778f02c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698