Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1630)

Unified Diff: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

Issue 2999563002: Add support for SDK outline in IKG. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
diff --git a/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart b/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
index d2437c29a96ca97e3b8b2c0b9e924a85c562af9f..025184ee65af91fa4c7666a482656d906a14428b 100644
--- a/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
+++ b/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
@@ -33,7 +33,7 @@ class IncrementalKernelGeneratorImpl implements IncrementalKernelGenerator {
/// The function to notify when files become used or unused, or `null`.
final WatchUsedFilesFn _watchFn;
- /// TODO(scheglov) document
+ /// The [KernelDriver] that is used to compute kernels.
KernelDriver _driver;
/// Latest compilation signatures produced by [computeDelta] for libraries.
@@ -42,8 +42,8 @@ class IncrementalKernelGeneratorImpl implements IncrementalKernelGenerator {
/// The object that provides additional information for tests.
_TestView _testView;
- IncrementalKernelGeneratorImpl(
- ProcessedOptions options, UriTranslator uriTranslator, this._entryPoint,
+ IncrementalKernelGeneratorImpl(ProcessedOptions options,
+ UriTranslator uriTranslator, List<int> sdkOutlineBytes, this._entryPoint,
{WatchUsedFilesFn watch})
: _logger = options.logger,
_watchFn = watch {
@@ -56,8 +56,8 @@ class IncrementalKernelGeneratorImpl implements IncrementalKernelGenerator {
return new Future.value();
}
- _driver =
- new KernelDriver(options, uriTranslator, fileAddedFn: onFileAdded);
+ _driver = new KernelDriver(options, uriTranslator,
+ sdkOutlineBytes: sdkOutlineBytes, fileAddedFn: onFileAdded);
}
/// Return the object that provides additional information for tests.

Powered by Google App Engine
This is Rietveld 408576698