Extract sorting method from AstInferrerEngine.

Extract sorting method from AstInferrerEngine.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/67daf4a303017505c1bff41bec37da0d7bbaca54

[Johnni Winther, 2017-08-07 11:44:48]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-08-08 00:30:46]

lgtm with suggestions

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/ast_inferrer_engine.dart (right):

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/ast_inferrer_engine.dart:103: static int
resolvedAstBucket(_element) {
rename to resolveAstApproxSize?

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right):

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:1122: Compiler compiler, int
bucket(MemberEntity member)) {
nit: `bucket` - since this is a function, how about `computeBucket` or
`assignBucket`?

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:1123: Map<int,
Set<MemberEntity>> methodSizes = groupMembers(compiler, bucket);


We seem to be mixing the terms "method-size" and "bucket". It might help to keep
it consistent. Ideas:
  - if we go with bucket: rename `methodSizes` to `buckets`, update dartdoc
above as well.
  - if we got with method-size: rename `bucket` as `computeSize` (below too)

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:1134: Compiler compiler, int
bucket(MemberEntity member)) {
here too (if we keep bucket, use `assignBucket` or even `getBucket`, or
`bucketOf`)

[Johnni Winther, 2017-08-09 08:10:45]

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/ast_inferrer_engine.dart (right):

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/ast_inferrer_engine.dart:103: static int
resolvedAstBucket(_element) {
On 2017/08/08 00:30:46, Siggi Cherem (dart-lang) wrote:
> rename to resolveAstApproxSize?

Done.

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right):

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:1122: Compiler compiler, int
bucket(MemberEntity member)) {
On 2017/08/08 00:30:46, Siggi Cherem (dart-lang) wrote:
> nit: `bucket` - since this is a function, how about `computeBucket` or
> `assignBucket`?

Renamed to `computeSize`

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:1123: Map<int,
Set<MemberEntity>> methodSizes = groupMembers(compiler, bucket);
On 2017/08/08 00:30:46, Siggi Cherem (dart-lang) wrote:
> 
> 
> We seem to be mixing the terms "method-size" and "bucket". It might help to
keep
> it consistent. Ideas:
>   - if we go with bucket: rename `methodSizes` to `buckets`, update dartdoc
> above as well.
>   - if we got with method-size: rename `bucket` as `computeSize` (below too) 

Used `size` instead of `bucket`

https://codereview.chromium.org/2999513003/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:1134: Compiler compiler, int
bucket(MemberEntity member)) {
On 2017/08/08 00:30:46, Siggi Cherem (dart-lang) wrote:
> here too (if we keep bucket, use `assignBucket` or even `getBucket`, or
> `bucketOf`)

Done.

[Johnni Winther, 2017-08-09 08:16:03]

Description was changed from

==========
Extract sorting method from AstInferrerEngine.
==========

to

==========
Extract sorting method from AstInferrerEngine.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/67daf4a303017505c1bff41bec37da0d7bbaca54
==========

[Johnni Winther, 2017-08-09 08:16:04]

Committed patchset #3 (id:40001) manually as
67daf4a303017505c1bff41bec37da0d7bbaca54 (presubmit successful).