Issue 2999473002: Scrub all non-identifier characters from JavaScript class names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2999473002: Scrub all non-identifier characters from JavaScript class names (Closed)

Created:
3 years, 4 months ago by sra1

Modified:
3 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Scrub all non-identifier characters from JavaScript class names Class names from kernel contain "&", "#", "^" etc BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/84b615df3dc4fe61d00c62338909ca8b163eb16a

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -57 lines)			Patch
M	pkg/compiler/lib/src/js_backend/namer.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	10 chunks	+3 lines, -55 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

3 years, 4 months ago (2017-08-07 20:13:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
84b615df3dc4fe61d00c62338909ca8b163eb16a (presubmit successful).