Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 2999403003: Properly annotate the checks needed when invoking function-typed objects. (Closed)

Created:
3 years, 4 months ago by Paul Berry
Modified:
3 years, 4 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Properly annotate the checks needed when invoking function-typed objects. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f6e2676571b0eb84a8a03903374ef1f087bf21d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -13 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 3 chunks +57 lines, -12 lines 0 comments Download
A pkg/front_end/testcases/runtime_checks/covariant_generic_parameter_tear_off.dart.strong.expect View 1 chunk +30 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/strong.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Paul Berry
3 years, 4 months ago (2017-08-23 20:08:28 UTC) #3
scheglov
lgtm
3 years, 4 months ago (2017-08-23 20:14:38 UTC) #4
Paul Berry
3 years, 4 months ago (2017-08-23 20:49:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f6e2676571b0eb84a8a03903374ef1f087bf21d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698