Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 2999353002: Adjusted compare-failures to report logdog URLs: Use a regular one! (Closed)

Created:
3 years, 4 months ago by eernst
Modified:
3 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjusted compare-failures to report logdog URLs: Use a regular one! R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/670fdcbac51e629cdc49f65758d98d335ea372d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/gardening/lib/src/compare_failures_impl.dart View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
For UX improvement, this adds a message to inform the user that a logdog url ...
3 years, 4 months ago (2017-08-21 13:56:20 UTC) #2
Johnni Winther
lgtm
3 years, 4 months ago (2017-08-21 14:00:22 UTC) #3
eernst
3 years, 4 months ago (2017-08-21 14:04:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
670fdcbac51e629cdc49f65758d98d335ea372d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698