Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2999323002: Replaced helper files that were accidentally removed during migration. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replaced helper files that were accidentally removed during migration. TBR=rnystrom@google.com Migrated test block 168 to Dart 2.0. Migrated some tests off of package:test to packages async_helper and expect. BUG= Committed: https://github.com/dart-lang/sdk/commit/0db8403cca2b66e8a4a9f8ad299bd0ed8765fbdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+424 lines, -4715 lines) Patch
D tests/lib/async/catch_errors_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib/async/dart2js_uncaught_error_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/lib/async/first_regression_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/lib/async/future_constructor2_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/lib/async/future_constructor_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/lib/async/future_delayed_error_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/lib/async/future_foreach_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/lib/async/future_microtask_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/lib/async/future_or_bad_type_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/lib/async/future_or_non_strong_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/lib/async/future_or_only_in_async_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/lib/async/future_or_strong_test.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D tests/lib/async/future_test.dart View 1 chunk +0 lines, -1240 lines 0 comments Download
D tests/lib/async/future_timeout_test.dart View 1 chunk +0 lines, -200 lines 0 comments Download
D tests/lib/async/future_value_chain2_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/lib/async/future_value_chain3_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib/async/future_value_chain4_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/lib/async/future_value_chain_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M tests/lib/lib.status View 6 chunks +0 lines, -11 lines 0 comments Download
M tests/lib_2/async/catch_errors.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib_2/async/catch_errors_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/dart2js_uncaught_error_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/lib_2/async/event_helper.dart View 1 chunk +184 lines, -0 lines 0 comments Download
A + tests/lib_2/async/first_regression_test.dart View 2 chunks +5 lines, -10 lines 0 comments Download
A + tests/lib_2/async/future_constructor2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_constructor_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_delayed_error_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_foreach_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_microtask_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/lib_2/async/future_or_bad_type_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A + tests/lib_2/async/future_or_only_in_async_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/lib_2/async/future_or_strong_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_test.dart View 10 chunks +23 lines, -19 lines 0 comments Download
A + tests/lib_2/async/future_timeout_test.dart View 4 chunks +114 lines, -86 lines 0 comments Download
A + tests/lib_2/async/future_value_chain2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_value_chain3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/future_value_chain4_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + tests/lib_2/async/future_value_chain_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib_2/async/futures_test.dart View 12 chunks +35 lines, -35 lines 0 comments Download
M tests/lib_2/lib_2.status View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/lib_2/lib_2_dart2js.status View 1 chunk +8 lines, -0 lines 0 comments Download
A tests/lib_2/lib_2_dartdevc.status View 1 chunk +10 lines, -0 lines 0 comments Download
A + tests/lib_2/lib_2_kernel.status View 1 chunk +5 lines, -0 lines 0 comments Download
A + tests/lib_2/lib_2_precompiled.status View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/lib_2/lib_2_vm.status View 1 chunk +12 lines, -0 lines 0 comments Download
D tests/lib_strong/async/catch_errors_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib_strong/async/dart2js_uncaught_error_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/lib_strong/async/first_regression_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/lib_strong/async/future_constructor2_test.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D tests/lib_strong/async/future_constructor_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/lib_strong/async/future_delayed_error_test.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tests/lib_strong/async/future_microtask_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/lib_strong/async/future_or_bad_type_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/lib_strong/async/future_or_non_strong_test.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D tests/lib_strong/async/future_or_only_in_async_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/lib_strong/async/future_or_strong_test.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D tests/lib_strong/async/future_test.dart View 1 chunk +0 lines, -1240 lines 0 comments Download
D tests/lib_strong/async/future_timeout_test.dart View 1 chunk +0 lines, -200 lines 0 comments Download
D tests/lib_strong/async/future_value_chain2_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/lib_strong/async/future_value_chain3_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib_strong/async/future_value_chain4_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/lib_strong/async/future_value_chain_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/lib_strong/async/futures_test.dart View 1 chunk +0 lines, -268 lines 0 comments Download
M tests/lib_strong/lib_strong.status View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
bkonyi
Committed patchset #1 (id:1) manually as 0db8403cca2b66e8a4a9f8ad299bd0ed8765fbdf.
3 years, 4 months ago (2017-08-21 08:11:38 UTC) #2
Bob Nystrom
3 years, 4 months ago (2017-08-23 21:59:01 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698