Issue 2999133002: Move some functions out of C++ header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2999133002: Move some functions out of C++ header files. (Closed)

Created:
3 years, 4 months ago by Kevin Millikin (Google)

Modified:
3 years, 4 months ago

Reviewers:
jensj

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Move some functions out of C++ header files. The helper functions for reading from the Kernel binary should be in the implementation file. BUG= R=jensj@google.com Committed: https://github.com/dart-lang/sdk/commit/7002f7765cc4e5d76b4f9d84acc36e7d456e7a7a

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+514 lines, -517 lines)			Patch
	M	runtime/vm/kernel_binary_flowgraph.h	View		14 chunks	+63 lines, -517 lines	0 comments	Download
	M	runtime/vm/kernel_binary_flowgraph.cc	View		1 chunk	+451 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Kevin Millikin (Google)

I just moved the implementations, and simplified some small things in the header file.

3 years, 4 months ago (2017-08-17 10:17:02 UTC) #2

Kevin Millikin (Google)

3 years, 4 months ago (2017-08-17 10:36:14 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7002f7765cc4e5d76b4f9d84acc36e7d456e7a7a (presubmit successful).