Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2999103002: Specify sentinels in the return type for evaluateInFrame. (Closed)

Created:
3 years, 4 months ago by devoncarew
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Specify sentinels in the return type for evaluateInFrame. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e3c8338fad113eb27cb9e4f856f2840ac8793e90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M runtime/vm/service/service.md View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/service/service_dev.md View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
devoncarew
Specify sentinels in the return type for evaluateInFrame() (they're already specified in the return type ...
3 years, 4 months ago (2017-08-16 21:05:08 UTC) #2
rmacnak
LGTM
3 years, 4 months ago (2017-08-16 21:51:42 UTC) #3
devoncarew
3 years, 4 months ago (2017-08-16 22:14:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e3c8338fad113eb27cb9e4f856f2840ac8793e90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698