Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2999043003: Use package:testing for tools/gardening (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -9 lines) Patch
A pkg/testing/pubspec.yaml View 1 chunk +5 lines, -0 lines 2 comments Download
A tools/gardening/analysis_options.yaml View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/gardening/bin/bot.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/gardening/bin/compare_failures.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gardening/bin/current_summary.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gardening/bin/find_shard.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gardening/bin/status_summary.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/gardening/bin/summary.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gardening/pubspec.yaml View 1 chunk +3 lines, -1 line 0 comments Download
M tools/gardening/test/compare_failures_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
A tools/gardening/test/gardening.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gardening/test/parse_build_results_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
A tools/gardening/testing.json View 1 chunk +33 lines, -0 lines 3 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
https://codereview.chromium.org/2999043003/diff/1/tools/gardening/testing.json File tools/gardening/testing.json (right): https://codereview.chromium.org/2999043003/diff/1/tools/gardening/testing.json#newcode19 tools/gardening/testing.json:19: "buildbot_data_test.dart" Is there a way to mark this as ...
3 years, 4 months ago (2017-08-16 12:24:28 UTC) #2
ahe
lgtm https://codereview.chromium.org/2999043003/diff/1/tools/gardening/testing.json File tools/gardening/testing.json (right): https://codereview.chromium.org/2999043003/diff/1/tools/gardening/testing.json#newcode19 tools/gardening/testing.json:19: "buildbot_data_test.dart" On 2017/08/16 12:24:28, Johnni Winther wrote: > ...
3 years, 4 months ago (2017-08-16 13:32:17 UTC) #3
ahe
FYI https://codereview.chromium.org/2999043003/diff/1/pkg/testing/pubspec.yaml File pkg/testing/pubspec.yaml (right): https://codereview.chromium.org/2999043003/diff/1/pkg/testing/pubspec.yaml#newcode5 pkg/testing/pubspec.yaml:5: dependencies: I think I used to have a ...
3 years, 4 months ago (2017-08-16 13:34:16 UTC) #4
Johnni Winther
https://codereview.chromium.org/2999043003/diff/1/pkg/testing/pubspec.yaml File pkg/testing/pubspec.yaml (right): https://codereview.chromium.org/2999043003/diff/1/pkg/testing/pubspec.yaml#newcode5 pkg/testing/pubspec.yaml:5: dependencies: On 2017/08/16 13:34:15, ahe wrote: > I think ...
3 years, 4 months ago (2017-08-16 13:44:02 UTC) #5
Johnni Winther
3 years, 4 months ago (2017-08-16 13:55:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f1b3a59da3be311e327dc78effc9a3c64ffa6ab7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698