Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 2999003002: Add more tested features to closure_test (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -52 lines) Patch
M pkg/compiler/lib/src/closure.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/annotated_code_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/closure/closure_test.dart View 8 chunks +217 lines, -31 lines 0 comments Download
A tests/compiler/dart2js/closure/data/captured_variable.dart View 1 1 chunk +43 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/closure/data/parameter_in_try.dart View 2 chunks +24 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_helper.dart View 5 chunks +29 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_test.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-15 14:19:23 UTC) #2
Emily Fortuna
lgtm. thank you https://codereview.chromium.org/2999003002/diff/1/tests/compiler/dart2js/closure/data/captured_variable.dart File tests/compiler/dart2js/closure/data/captured_variable.dart (right): https://codereview.chromium.org/2999003002/diff/1/tests/compiler/dart2js/closure/data/captured_variable.dart#newcode17 tests/compiler/dart2js/closure/data/captured_variable.dart:17: ; why the weird whitespace with ...
3 years, 4 months ago (2017-08-16 00:55:12 UTC) #3
Johnni Winther
https://codereview.chromium.org/2999003002/diff/1/tests/compiler/dart2js/closure/data/captured_variable.dart File tests/compiler/dart2js/closure/data/captured_variable.dart (right): https://codereview.chromium.org/2999003002/diff/1/tests/compiler/dart2js/closure/data/captured_variable.dart#newcode17 tests/compiler/dart2js/closure/data/captured_variable.dart:17: ; On 2017/08/16 00:55:11, Emily Fortuna wrote: > why ...
3 years, 4 months ago (2017-08-16 07:30:19 UTC) #4
Johnni Winther
3 years, 4 months ago (2017-08-16 07:30:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9ab9598918dba841098288b7de67415bf41188ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698