Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: tools/gardening/lib/src/buildbot_loading.dart

Issue 2998993002: Use timeout to read most recent build from http (Closed)
Patch Set: Fix test Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gardening/lib/src/buildbot_loading.dart
diff --git a/tools/gardening/lib/src/buildbot_loading.dart b/tools/gardening/lib/src/buildbot_loading.dart
index 6767bd01eeb50f01267cc8f943240cc1b19d4eb5..93bd62cf3110d39a255d952b8434739896dd0d31 100644
--- a/tools/gardening/lib/src/buildbot_loading.dart
+++ b/tools/gardening/lib/src/buildbot_loading.dart
@@ -33,11 +33,12 @@ Future<BuildResult> _readBuildResult(
/// Fetches test data for [buildUri] through the buildbot stdio.
Future<BuildResult> readBuildResultFromHttp(
- HttpClient client, BuildUri buildUri) {
+ HttpClient client, BuildUri buildUri,
+ [Duration timeout]) {
Future<String> read() async {
Uri uri = buildUri.toUri();
log('Reading buildbot results: $uri');
- return readUriAsText(client, uri);
+ return readUriAsText(client, uri, timeout);
}
return _readBuildResult(buildUri, read);

Powered by Google App Engine
This is Rietveld 408576698