Use timeout to read most recent build from http

tools/gardening/lib/src/util.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:args/args.dart';
 
@@ skipping 46 matching lines @@
 
 class HttpException implements Exception {
   final Uri uri;
   final int statusCode;
 
   HttpException(this.uri, this.statusCode);
 
   String toString() => '$uri: $statusCode';
 }
 
+class TimeoutException implements Exception {

[floitsch, 2017/08/15 11:26:35]

I would have used the builtin TimeoutException class.

It doesn't have a uri field, but it doesn't look like that one is used anyway.

[Johnni Winther, 2017/08/15 12:51:27]

Done.

+  final Uri uri;
+
+  TimeoutException(this.uri);
+
+  String toString() => '$uri timeout';
+}
+
 /// Reads the content of [uri] as text.
-Future<String> readUriAsText(HttpClient client, Uri uri) async {
+Future<String> readUriAsText(
+    HttpClient client, Uri uri, Duration timeout) async {
   HttpClientRequest request = await client.getUrl(uri);
   HttpClientResponse response = await request.close();
   if (response.statusCode != 200) {
     response.drain();
     throw new HttpException(uri, response.statusCode);
   }
-  return response.transform(UTF8.decoder).join();
+  List<int> data = <int>[];
+  Timer timer;
+  Completer<String> completer = new Completer<String>();
+  StreamSubscription subscription = response.listen((List<int> buffer) {

[floitsch, 2017/08/15 11:26:35]

You could consider using .timeout from the Stream class.

return response
    .timeout(timeout)
    .toList()
    .then((chunks) => chunks.expand((x) => x).toList());


The expand might be too expensive, but then you could just do a small loop in
the .then (calling `addAll` on a fresh list.

[Johnni Winther, 2017/08/15 12:51:27]

Done.

+    data.addAll(buffer);
+  }, onDone: () {
+    timer?.cancel();
+    completer.complete(UTF8.decode(data));
+  }, cancelOnError: true);
+  if (timeout != null) {
+    timer = new Timer(timeout, () {
+      subscription.cancel();
+      completer.completeError(new TimeoutException(uri));
+    });
+  }
+  return completer.future;
 }
 
 ArgParser createArgParser() {
   ArgParser argParser = new ArgParser(allowTrailingOptions: true);
   argParser.addFlag('help', help: "Help");
   argParser.addFlag('verbose',
       abbr: 'v', negatable: false, help: "Turn on logging output.");
   argParser.addFlag('no-cache', help: "Disable caching.");
   argParser.addOption('cache',
       help: "Use <dir> for caching test output.\n"
           "Defaults to 'temp/gardening-cache/'.");
   argParser.addFlag('logdog',
       negatable: false, help: "Pull test results from logdog.");
   return argParser;
 }
 
 void processArgResults(ArgResults argResults) {
   if (argResults['verbose']) {
     LOG = true;
   }
   if (argResults['cache'] != null) {
     cache.base = Uri.base.resolve('${argResults['cache']}/');
   }
   if (argResults['no-cache']) {
     cache.base = null;
   }
 }