Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2998963002: Revert "Revert "Introduce IKG into kernel-service to support incremental compilation."" (Closed)

Created:
3 years, 4 months ago by aam
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Introduce IKG into kernel-service to support incremental compilation."" This reverts commit c35510d8352ee3ce9d935db75d0b8966b98b6b45 with fix for the build - remove implicit temporary array in TestCase::LoadTestScript. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/a9afb54d6d23a6320aa7e395c882659e1bdd1447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -144 lines) Patch
M runtime/include/dart_api.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/isolate_reload_test.cc View 1 chunk +211 lines, -0 lines 0 comments Download
M runtime/vm/kernel_isolate.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/kernel_isolate.cc View 5 chunks +63 lines, -40 lines 0 comments Download
M runtime/vm/unit_test.h View 3 chunks +16 lines, -1 line 0 comments Download
M runtime/vm/unit_test.cc View 6 chunks +104 lines, -48 lines 0 comments Download
M utils/kernel-service/kernel-service.dart View 4 chunks +149 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
aam
3 years, 4 months ago (2017-08-14 21:34:12 UTC) #3
aam
PTAL, thanks!
3 years, 4 months ago (2017-08-15 15:37:23 UTC) #4
siva
lgtm
3 years, 4 months ago (2017-08-15 15:56:09 UTC) #5
aam
3 years, 4 months ago (2017-08-15 16:03:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9afb54d6d23a6320aa7e395c882659e1bdd1447 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698