Add more diagnostics to the deferred loading implementation.

Add more diagnostics to the deferred loading implementation.

BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/9c4b1991b438b8479497ec8c0e79728fe9403bc9

[Siggi Cherem (dart-lang), 2017-08-14 18:14:22]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com, sra@google.com

[Siggi Cherem (dart-lang), 2017-08-14 18:14:22]

Any suggestions on how to test this?

I've been playing with this locally by running my own server, and then mutating
the generated output to produce erroneous cases.

I guess I could write the same process as a VM unit test that launches DRT?
Other ideas?

https://codereview.chromium.org/2998943002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart (right):

https://codereview.chromium.org/2998943002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart:1712: if (hunk ==
null) {
technically we should never get here because I also added a check where we call
initalizeLoadedHunk

[sra1, 2017-08-14 18:22:52]

LGTM

I might try to test this by JS polyfill to override the browser's requests. It
might be very tricky for the 'normal' script injection case.

[sra1, 2017-08-14 18:24:08]

https://codereview.chromium.org/2998943002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/2998943002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:3651: final List<String>
_eventLog = <String>[];
How do we get hold of this in a crash log?

[Siggi Cherem (dart-lang), 2017-08-14 18:59:43]

https://codereview.chromium.org/2998943002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/2998943002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:3651: final List<String>
_eventLog = <String>[];
On 2017/08/14 18:24:08, sra1 wrote:
> How do we get hold of this in a crash log?

I'm attaching it on the exceptions that we throw explicitly, are you suggesting
we make it more easily accessible as well (e.g. make it an embedded global or
something that is not renamed and can be accessed from JS?)

[sra1, 2017-08-14 19:38:30]

lgtm

https://codereview.chromium.org/2998943002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/2998943002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:3651: final List<String>
_eventLog = <String>[];
On 2017/08/14 18:59:43, Siggi Cherem (dart-lang) wrote:
> On 2017/08/14 18:24:08, sra1 wrote:
> > How do we get hold of this in a crash log?
> 
> I'm attaching it on the exceptions that we throw explicitly, are you
suggesting
> we make it more easily accessible as well (e.g. make it an embedded global or
> something that is not renamed and can be accessed from JS?)

That is fine.

[Siggi Cherem (dart-lang), 2017-08-14 20:37:26]

Description was changed from

==========
Add more diagnostics to the deferred loading implementation.

BUG=
==========

to

==========
Add more diagnostics to the deferred loading implementation.

BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9c4b1991b438b8479497ec8c0e79728fe9403bc9
==========

[Siggi Cherem (dart-lang), 2017-08-14 20:37:30]

Committed patchset #1 (id:1) manually as
9c4b1991b438b8479497ec8c0e79728fe9403bc9 (presubmit successful).