dashboard/dashboard/pinpoint/models/change_test.py - Issue 2998883002: [pinpoint] Strip '.git' from the end of repository URLs in DEPS files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dashboard/dashboard/pinpoint/models/change_test.py

Issue 2998883002: [pinpoint] Strip '.git' from the end of repository URLs in DEPS files. (Closed)

Patch Set: Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dashboard/dashboard/pinpoint/models/change_test.py

diff --git a/dashboard/dashboard/pinpoint/models/change_test.py b/dashboard/dashboard/pinpoint/models/change_test.py

index 295beedf45bfec6004ae72e5c90ffa8b0da535c9..e71826aac9d944ee0f3669e772645a00f0c57c36 100644

--- a/dashboard/dashboard/pinpoint/models/change_test.py

+++ b/dashboard/dashboard/pinpoint/models/change_test.py

@@ -109,7 +109,9 @@ class ChangeTest(testing_common.TestCase):

del repository_url

del path

if git_hash == '0e57e2b':

- return 'deps = {"src/catapult": "%s@0000000"}' % _CATAPULT_URL

+ # Also test the stripping of '.git' from repository URLs.

+ return 'deps = {"src/catapult": "%s@0000000"}' % (

+ _CATAPULT_URL + '.git')

if git_hash == 'babe852':

return 'deps = {"src/catapult": "%s@2222222"}' % _CATAPULT_URL

raise NotImplementedError()

« no previous file with comments | « dashboard/dashboard/pinpoint/models/change.py ('k') | no next file » | no next file with comments »