Adds WebWorker support to NetInfo v3.

Adds WebWorker support to NetInfo v3.

Design doc: https://docs.google.com/a/chromium.org/document/d/1LTk9uVMGi4kurzcF5ellsAJReTF31fFJMHrQwSVtBjc/

BUG=368358
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175281

[jkarlin, 2014-05-27 20:55:29]

haraken@chromium.org: Please review changes in Source/modules/

Note that this cl depends on crrev.com/291203002

[haraken, 2014-05-27 22:54:56]

modules/ LGTM in terms of implementation (I don't fully understand the NetInfo
APIs).

https://codereview.chromium.org/299883004/diff/20001/Source/modules/netinfo/W...
File Source/modules/netinfo/WorkerNavigatorNetworkInfoConnection.cpp (right):

https://codereview.chromium.org/299883004/diff/20001/Source/modules/netinfo/W...
Source/modules/netinfo/WorkerNavigatorNetworkInfoConnection.cpp:54: if
(!m_connection && context)

I think |context| shouldn't be 0. You can add ASSERT(context) instead.

https://codereview.chromium.org/299883004/diff/20001/Source/modules/netinfo/W...
File Source/modules/netinfo/WorkerNavigatorNetworkInfoConnection.h (right):

https://codereview.chromium.org/299883004/diff/20001/Source/modules/netinfo/W...
Source/modules/netinfo/WorkerNavigatorNetworkInfoConnection.h:35: explicit
WorkerNavigatorNetworkInfoConnection(WorkerNavigator&, ExecutionContext*);

Drop explicit.

[jkarlin, 2014-05-29 13:13:49]

Haraken:  Please take another look after the refactor. I removed the
WillBeGarbageCollected from WorkerNavigatorNetworkInformation.idl. Is that okay?
 I don't see it on similar interfaces in other modules.

https://codereview.chromium.org/299883004/diff/20001/Source/modules/netinfo/W...
File Source/modules/netinfo/WorkerNavigatorNetworkInfoConnection.cpp (right):

https://codereview.chromium.org/299883004/diff/20001/Source/modules/netinfo/W...
Source/modules/netinfo/WorkerNavigatorNetworkInfoConnection.cpp:54: if
(!m_connection && context)
On 2014/05/27 22:54:57, haraken wrote:
> 
> I think |context| shouldn't be 0. You can add ASSERT(context) instead.

Done.

https://codereview.chromium.org/299883004/diff/20001/Source/modules/netinfo/W...
File Source/modules/netinfo/WorkerNavigatorNetworkInfoConnection.h (right):

https://codereview.chromium.org/299883004/diff/20001/Source/modules/netinfo/W...
Source/modules/netinfo/WorkerNavigatorNetworkInfoConnection.h:35: explicit
WorkerNavigatorNetworkInfoConnection(WorkerNavigator&, ExecutionContext*);
On 2014/05/27 22:54:57, haraken wrote:
> 
> Drop explicit.

Done.

[haraken, 2014-05-29 13:57:16]

+zerny

On 2014/05/29 13:13:49, jkarlin wrote:
> Haraken:  Please take another look after the refactor. I removed the
> WillBeGarbageCollected from WorkerNavigatorNetworkInformation.idl. Is that
okay?
>  I don't see it on similar interfaces in other modules.

oh, nice catch. Yes, it's not needed since WorkerNavigatorNetworkInformation is
a partial interface of WorkerNavigator, which has [WillBeGarbageCollected].

[adamk, 2014-05-30 22:32:19]

lgtm

[jkarlin, 2014-06-01 13:31:19]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-06-01 13:31:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/299883004/80001

[commit-bot: I haz the power, 2014-06-01 14:52:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9743)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10057)

[commit-bot: I haz the power, 2014-06-01 14:55:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-01 14:55:00]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[jkarlin, 2014-06-02 12:53:07]

Regolded some layout tests, PTAL.

[haraken, 2014-06-02 13:14:01]

LGTM

[jkarlin, 2014-06-02 13:33:32]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-06-02 13:33:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/299883004/120001

[commit-bot: I haz the power, 2014-06-02 14:18:48]

Change committed as 175281