Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: pkg/analysis_server/benchmark/benchmarks.dart

Issue 2998813002: Tweaks to the analysis server benchmarks. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/benchmark/perf/benchmarks_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/benchmark/benchmarks.dart
diff --git a/pkg/analysis_server/benchmark/benchmarks.dart b/pkg/analysis_server/benchmark/benchmarks.dart
index bfc24daad3e0e4f1e2fc3ed4f91ce8e4a7752474..e79f7608b84bb97a4980ca33822dab66791d1969 100644
--- a/pkg/analysis_server/benchmark/benchmarks.dart
+++ b/pkg/analysis_server/benchmark/benchmarks.dart
@@ -18,7 +18,7 @@ import 'perf/benchmarks_impl.dart';
Future main(List<String> args) async {
final List<Benchmark> benchmarks = [
new ColdAnalysisBenchmark(),
- new AnalysisBenchmark(),
+ new AnalysisBenchmark()
];
CommandRunner runner = new CommandRunner(
@@ -115,10 +115,7 @@ class RunCommand extends Command {
time.stop();
print('Finished in ${time.elapsed.inSeconds} seconds.\n');
- Map m = {
- 'benchmark': benchmarkId,
- 'result': result.toJson(),
- };
+ Map m = {'benchmark': benchmarkId, 'result': result.toJson()};
print(JSON.encode(m));
} catch (error, st) {
print('$benchmarkId threw exception: $error');
@@ -133,7 +130,7 @@ abstract class Benchmark {
final String description;
final bool enabled;
- /// One of 'memory' or 'cpu'.
+ /// One of 'memory', 'cpu', or 'group'.
final String kind;
Benchmark(this.id, this.description, {this.enabled: true, this.kind: 'cpu'});
« no previous file with comments | « no previous file | pkg/analysis_server/benchmark/perf/benchmarks_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698