Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: telemetry/telemetry/benchmark.py

Issue 2998773002: [Telemetry] Reuse shared state between story runs (Closed)
Patch Set: fix unittest Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/internal/story_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/benchmark.py
diff --git a/telemetry/telemetry/benchmark.py b/telemetry/telemetry/benchmark.py
index 79f72179a40058a76017ef9a6551544a8ebe8f9c..3cea7caa5cd21ff0108665eaf34c33414e432ff4 100644
--- a/telemetry/telemetry/benchmark.py
+++ b/telemetry/telemetry/benchmark.py
@@ -104,43 +104,6 @@ class Benchmark(command_line.Command):
def Name(cls):
return '%s.%s' % (cls.__module__.split('.')[-1], cls.__name__)
- @classmethod
- def ShouldTearDownStateAfterEachStoryRun(cls):
- """Override to specify whether to tear down state after each story run.
-
- Tearing down all states after each story run, e.g., clearing profiles,
- stopping the browser, stopping local server, etc. So the browser will not be
- reused among multiple stories. This is particularly useful to get the
- startup part of launching the browser in each story.
-
- This should only be used by TimelineBasedMeasurement (TBM) benchmarks, but
- not by PageTest based benchmarks.
- """
- return True
-
- # NOTE: this is a temporary workaround for crbug.com/645329, do not rely on
- # this as a stable public API as we may remove this without public notice.
- @classmethod
- def IsShouldTearDownStateAfterEachStoryRunOverriden(cls):
- return (cls.ShouldTearDownStateAfterEachStoryRun.__func__ !=
- Benchmark.ShouldTearDownStateAfterEachStoryRun.__func__)
-
- @classmethod
- def ShouldTearDownStateAfterEachStorySetRun(cls):
- """Override to specify whether to tear down state after each story set run.
-
- Defaults to True in order to reset the state and make individual story set
- repeats more independent of each other. The intended effect is to average
- out noise in measurements between repeats.
-
- Long running benchmarks willing to stess test the browser and have it run
- for long periods of time may switch this value to False.
-
- This should only be used by TimelineBasedMeasurement (TBM) benchmarks, but
- not by PageTest based benchmarks.
- """
- return True
-
@classmethod
def AddCommandLineArgs(cls, parser):
group = optparse.OptionGroup(parser, '%s test options' % cls.Name())
« no previous file with comments | « no previous file | telemetry/telemetry/internal/story_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698