Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: runtime/vm/service_isolate.cc

Issue 2998713002: [vm, gardening] Move --trace-service output to stderr. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service.cc ('k') | runtime/vm/thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_isolate.cc
diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc
index 1826f16fbe82444d652a94eb75df1cdc6f68abd0..4aacb9189d146e7a09613c0f1dc49b5a1f826e4d 100644
--- a/runtime/vm/service_isolate.cc
+++ b/runtime/vm/service_isolate.cc
@@ -199,8 +199,8 @@ bool ServiceIsolate::SendIsolateStartupMessage() {
writer.WriteMessage(list);
intptr_t len = writer.BytesWritten();
if (FLAG_trace_service) {
- OS::Print("vm-service: Isolate %s %" Pd64 " registered.\n",
- name.ToCString(), Dart_GetMainPortId());
+ OS::PrintErr("vm-service: Isolate %s %" Pd64 " registered.\n",
+ name.ToCString(), Dart_GetMainPortId());
}
return PortMap::PostMessage(
new Message(port_, data, len, Message::kNormalPriority));
@@ -227,8 +227,8 @@ bool ServiceIsolate::SendIsolateShutdownMessage() {
writer.WriteMessage(list);
intptr_t len = writer.BytesWritten();
if (FLAG_trace_service) {
- OS::Print("vm-service: Isolate %s %" Pd64 " deregistered.\n",
- name.ToCString(), Dart_GetMainPortId());
+ OS::PrintErr("vm-service: Isolate %s %" Pd64 " deregistered.\n",
+ name.ToCString(), Dart_GetMainPortId());
}
return PortMap::PostMessage(
new Message(port_, data, len, Message::kNormalPriority));
@@ -242,7 +242,7 @@ void ServiceIsolate::SendServiceExitMessage() {
return;
}
if (FLAG_trace_service) {
- OS::Print("vm-service: sending service exit message.\n");
+ OS::PrintErr("vm-service: sending service exit message.\n");
}
PortMap::PostMessage(new Message(port_, exit_message_, exit_message_length_,
Message::kNormalPriority));
@@ -366,7 +366,7 @@ class RunServiceTask : public ThreadPool::Task {
protected:
static void ShutdownIsolate(uword parameter) {
if (FLAG_trace_service) {
- OS::Print("vm-service: ShutdownIsolate\n");
+ OS::PrintErr("vm-service: ShutdownIsolate\n");
}
Isolate* I = reinterpret_cast<Isolate*>(parameter);
ASSERT(ServiceIsolate::IsServiceIsolate(I));
@@ -396,7 +396,7 @@ class RunServiceTask : public ThreadPool::Task {
// Shut the isolate down.
Dart::ShutdownIsolate(I);
if (FLAG_trace_service) {
- OS::Print("vm-service: Shutdown.\n");
+ OS::PrintErr("vm-service: Shutdown.\n");
}
ServiceIsolate::FinishedExiting();
}
@@ -411,7 +411,7 @@ class RunServiceTask : public ThreadPool::Task {
Library::Handle(Z, I->object_store()->root_library());
if (root_library.IsNull()) {
if (FLAG_trace_service) {
- OS::Print("vm-service: Embedder did not install a script.");
+ OS::PrintErr("vm-service: Embedder did not install a script.");
}
// Service isolate is not supported by embedder.
return false;
@@ -424,7 +424,7 @@ class RunServiceTask : public ThreadPool::Task {
if (entry.IsNull()) {
// Service isolate is not supported by embedder.
if (FLAG_trace_service) {
- OS::Print("vm-service: Embedder did not provide a main function.");
+ OS::PrintErr("vm-service: Embedder did not provide a main function.");
}
return false;
}
@@ -436,8 +436,8 @@ class RunServiceTask : public ThreadPool::Task {
// Service isolate did not initialize properly.
if (FLAG_trace_service) {
const Error& error = Error::Cast(result);
- OS::Print("vm-service: Calling main resulted in an error: %s",
- error.ToErrorCString());
+ OS::PrintErr("vm-service: Calling main resulted in an error: %s",
+ error.ToErrorCString());
}
if (result.IsUnwindError()) {
return true;
« no previous file with comments | « runtime/vm/service.cc ('k') | runtime/vm/thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698