Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2998673002: Added ThisVariable in scoping and the captured scope of initialized fields. (Closed)

Created:
3 years, 4 months ago by Emily Fortuna
Modified:
3 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added ThisVariable in scoping and the captured scope of initialized fields. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/3aee4694abd3a3f212508deaa21ee8d5f0c59f00

Patch Set 1 : . #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
M pkg/compiler/lib/src/js_model/closure.dart View 1 8 chunks +19 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/js_model/closure_visitors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 6 chunks +10 lines, -1 line 0 comments Download
M tests/language_2/language_2_dart2js.status View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Emily Fortuna
currently re-running tests to update the status files.
3 years, 4 months ago (2017-08-09 00:27:10 UTC) #2
sra1
lgtm
3 years, 4 months ago (2017-08-09 00:31:40 UTC) #4
Emily Fortuna
3 years, 4 months ago (2017-08-09 16:09:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
3aee4694abd3a3f212508deaa21ee8d5f0c59f00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698