Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2998663002: Reverts CLs related to the TLAB due to heap exhaustion. (Closed)

Created:
3 years, 4 months ago by danunez
Modified:
3 years, 4 months ago
Reviewers:
regis, rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reverts CLs related to the TLAB due to heap exhaustion. Revert "Attempts to fix bugs introduced in 8b6fcf50e85d." This reverts commit 7568e1f18e39dcaaf5d718ab6d8e150a976be1c7. Revert "Changes calculation of Scavenger's UsedInWords" This reverts commit 91470e721167f9ab74273bf5398ae94a88ee4188. Revert "Fixes the regression caused by 7568e1f18e." This reverts commit 479db734e339060fcdfd98154d5dc39b1285bc66. BUG= Committed: https://github.com/dart-lang/sdk/commit/91662ce57927f433a243605c0dd737f9ba6e478d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -123 lines) Patch
M runtime/vm/heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/heap.cc View 2 chunks +9 lines, -58 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/scavenger.h View 7 chunks +7 lines, -26 lines 0 comments Download
M runtime/vm/scavenger.cc View 8 chunks +26 lines, -33 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
danunez
3 years, 4 months ago (2017-08-08 21:49:36 UTC) #2
danunez
3 years, 4 months ago (2017-08-08 21:49:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91662ce57927f433a243605c0dd737f9ba6e478d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698