Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2998603002: Make AnalyzerWorkerLoop AsyncWorkerLoop. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make AnalyzerWorkerLoop AsyncWorkerLoop. BuildMode will be switched to AnalysisDriver, so will become async. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6515a80b212e97cb6f05043ed0ba2f71ab972c1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M pkg/analyzer_cli/lib/src/build_mode.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M pkg/analyzer_cli/test/build_mode_test.dart View 7 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 4 months ago (2017-08-07 21:57:39 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-08-08 13:40:14 UTC) #2
scheglov
3 years, 4 months ago (2017-08-08 15:11:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6515a80b212e97cb6f05043ed0ba2f71ab972c1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698