Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2998573002: Add type inference for invalid constructor initializers. (Closed)

Created:
3 years, 4 months ago by Paul Berry
Modified:
3 years, 4 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add type inference for invalid constructor initializers. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/107335c1d03752165380e09bacecf27a2c824f39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paul Berry
3 years, 4 months ago (2017-08-07 18:39:41 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-07 20:33:15 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 107335c1d03752165380e09bacecf27a2c824f39 (presubmit successful).
3 years, 4 months ago (2017-08-07 20:37:33 UTC) #5
ahe
3 years, 4 months ago (2017-08-08 13:35:56 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698