Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2998553002: Update status for dartdevc on Windows. (Closed)

Created:
3 years, 4 months ago by Bill Hesse
Modified:
3 years, 4 months ago
Reviewers:
sortie
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for dartdevc on Windows. BUG=https://github.com/dart-lang/sdk/issues/30336 BUG=https://github.com/dart-lang/sdk/issues/21527 R=sortie@google.com Committed: https://github.com/dart-lang/sdk/commit/d109fe7f1ad3354a585d437e2a1a31f0f9dd6350

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M tests/language_strong/language_strong.status View 2 chunks +5 lines, -1 line 1 comment Download
M tests/lib_strong/lib_strong.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
3 years, 4 months ago (2017-08-07 11:33:11 UTC) #2
sortie
lgtm with comment on stray mistake https://codereview.chromium.org/2998553002/diff/1/tests/language_strong/language_strong.status File tests/language_strong/language_strong.status (right): https://codereview.chromium.org/2998553002/diff/1/tests/language_strong/language_strong.status#newcode648 tests/language_strong/language_strong.status:648: [$compiler == dart2analyzer ...
3 years, 4 months ago (2017-08-07 11:37:10 UTC) #3
Bill Hesse
3 years, 4 months ago (2017-08-07 11:37:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d109fe7f1ad3354a585d437e2a1a31f0f9dd6350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698