Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tests/compiler/dart2js/equivalence/check_functions.dart

Issue 2998543002: Handle js interop members in impact computation. (Closed)
Patch Set: Updated cf. comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_impact.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/equivalence/check_functions.dart
diff --git a/tests/compiler/dart2js/equivalence/check_functions.dart b/tests/compiler/dart2js/equivalence/check_functions.dart
index 6b59b291d7f988c14b898c4a82b2b1eaca2d4548..71a9c4166d8b359c77a63b3ffccd78c2e4dbbff5 100644
--- a/tests/compiler/dart2js/equivalence/check_functions.dart
+++ b/tests/compiler/dart2js/equivalence/check_functions.dart
@@ -98,8 +98,8 @@ void checkNativeData(NativeDataImpl data1, NativeDataImpl data2,
data1,
data2,
'jsInteropLibraryNames',
- data1.jsInteropLibraryNames,
- data2.jsInteropLibraryNames,
+ data1.jsInteropLibraries,
+ data2.jsInteropLibraries,
strategy.elementEquivalence,
equality);
@@ -115,8 +115,8 @@ void checkNativeData(NativeDataImpl data1, NativeDataImpl data2,
data1,
data2,
'jsInteropClassNames',
- data1.jsInteropClassNames,
- data2.jsInteropClassNames,
+ data1.jsInteropClasses,
+ data2.jsInteropClasses,
strategy.elementEquivalence,
equality);
@@ -124,8 +124,8 @@ void checkNativeData(NativeDataImpl data1, NativeDataImpl data2,
data1,
data2,
'jsInteropMemberNames',
- data1.jsInteropMemberNames,
- data2.jsInteropMemberNames,
+ data1.jsInteropMembers,
+ data2.jsInteropMembers,
strategy.elementEquivalence,
equality);
}
@@ -386,11 +386,16 @@ void checkNativeBasicData(NativeBasicDataImpl data1, NativeBasicDataImpl data2,
data1,
data2,
'jsInteropLibraries',
- data1.jsInteropLibraries,
- data2.jsInteropLibraries,
+ data1.jsInteropLibraries.keys,
+ data2.jsInteropLibraries.keys,
+ strategy.elementEquivalence);
+ checkSetEquivalence(
+ data1,
+ data2,
+ 'jsInteropClasses',
+ data1.jsInteropClasses.keys,
+ data2.jsInteropClasses.keys,
strategy.elementEquivalence);
- checkSetEquivalence(data1, data2, 'jsInteropClasses', data1.jsInteropClasses,
- data2.jsInteropClasses, strategy.elementEquivalence);
}
void checkBackendUsage(
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_impact.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698