Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: tests/compiler/dart2js/kernel/impact_test.dart

Issue 2998543002: Handle js interop members in impact computation. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/kernel/impact_test.dart
diff --git a/tests/compiler/dart2js/kernel/impact_test.dart b/tests/compiler/dart2js/kernel/impact_test.dart
index b420403b13a598c20a50d27ab14320c7b1013957..7a89f60cef8f46efcdec82d8a9f871bdbd392642 100644
--- a/tests/compiler/dart2js/kernel/impact_test.dart
+++ b/tests/compiler/dart2js/kernel/impact_test.dart
@@ -30,7 +30,11 @@ import 'test_helpers.dart';
const Map<String, String> SOURCE = const <String, String>{
// Pretend this is a dart2js_native test to allow use of 'native' keyword.
'sdk/tests/compiler/dart2js_native/main.dart': r'''
-import 'dart:_foreign_helper';
+@JS()
+library test;
+
+import 'dart:_foreign_helper' as foreign show JS;
+import 'dart:_foreign_helper' hide JS;
import 'dart:_js_helper';
import 'dart:_interceptors';
import 'dart:_native_typed_data';
@@ -40,6 +44,7 @@ import 'dart:html_common';
import 'dart:math';
import 'dart:typed_data';
import 'dart:web_sql';
+import 'package:js/js.dart';
import 'helper.dart';
main() {
@@ -202,6 +207,8 @@ main() {
testNamedMixinInstantiation();
testGenericMixinInstantiation();
testGenericNamedMixinInstantiation();
+ testJsInteropMethod();
+ testJsInteropClass();
}
testEmpty() {}
@@ -669,7 +676,7 @@ testInstanceGenericMethod() {
}
testDynamicPrivateMethodInvoke([o]) => o._privateMethod();
-testJSCall() => JS('int|bool|NativeUint8List|Rectangle|IdbFactory|'
+testJSCall() => foreign.JS('int|bool|NativeUint8List|Rectangle|IdbFactory|'
'SqlDatabase|TypedData|ContextAttributes', '#', null);
@JSName('foo')
@SupportedBrowser(SupportedBrowser.CHROME)
@@ -691,6 +698,17 @@ testMixinInstantiation() => new Sub();
testNamedMixinInstantiation() => new NamedMixin();
testGenericMixinInstantiation() => new GenericSub<int, String>();
testGenericNamedMixinInstantiation() => new GenericNamedMixin<int, String>();
+
+@JS()
+external int testJsInteropMethod();
+
+@JS()
+class JsInteropClass {
+ @JS()
+ external double method();
+}
+
+testJsInteropClass() => new JsInteropClass().method();
''',
'sdk/tests/compiler/dart2js_native/helper.dart': '''
import 'dart:_js_helper';

Powered by Google App Engine
This is Rietveld 408576698