Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_impact.dart

Issue 2998543002: Handle js interop members in impact computation. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/kernel_impact.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_impact.dart b/pkg/compiler/lib/src/ssa/kernel_impact.dart
index a4e2a3018ae137291e33272e0911871d8f604587..3fd5548e4bbcaa742e0bd1f612581afa86ebf830 100644
--- a/pkg/compiler/lib/src/ssa/kernel_impact.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_impact.dart
@@ -165,9 +165,11 @@ class KernelImpactBuilder extends ir.Visitor {
handleAsyncMarker(procedure.function.asyncMarker);
if (procedure.isExternal &&
!elementAdapter.isForeignLibrary(procedure.enclosingLibrary)) {
- // TODO(redemption): Provide the correct value for [isJsInterop].
+ MemberEntity member = elementAdapter.getMember(procedure);
+ bool isJsInterop =
+ elementAdapter.nativeBasicData.isJsInteropMember(member);
impactBuilder.registerNativeData(elementAdapter
- .getNativeBehaviorForMethod(procedure, isJsInterop: false));
+ .getNativeBehaviorForMethod(procedure, isJsInterop: isJsInterop));
}
return impactBuilder;
}

Powered by Google App Engine
This is Rietveld 408576698