Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: pkg/compiler/lib/src/diagnostics/messages.dart

Issue 2998543002: Handle js interop members in impact computation. (Closed)
Patch Set: Updated cf. comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend_serialization.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// The messages in this file should follow the [Guide for Writing 5 /// The messages in this file should follow the [Guide for Writing
6 /// Diagnostics](../../../../front_end/lib/src/fasta/diagnostics.md). 6 /// Diagnostics](../../../../front_end/lib/src/fasta/diagnostics.md).
7 /// 7 ///
8 /// Other things to keep in mind: 8 /// Other things to keep in mind:
9 /// 9 ///
10 /// An INFO message should always be preceded by a non-INFO message, and the 10 /// An INFO message should always be preceded by a non-INFO message, and the
(...skipping 2385 matching lines...) Expand 10 before | Expand all | Expand 10 after
2396 main() { 2396 main() {
2397 new Foo()[0] = 1; 2397 new Foo()[0] = 1;
2398 } 2398 }
2399 """ 2399 """
2400 ]), 2400 ]),
2401 2401
2402 MessageKind.JS_OBJECT_LITERAL_CONSTRUCTOR_WITH_POSITIONAL_ARGUMENTS: 2402 MessageKind.JS_OBJECT_LITERAL_CONSTRUCTOR_WITH_POSITIONAL_ARGUMENTS:
2403 const MessageTemplate( 2403 const MessageTemplate(
2404 MessageKind 2404 MessageKind
2405 .JS_OBJECT_LITERAL_CONSTRUCTOR_WITH_POSITIONAL_ARGUMENTS, 2405 .JS_OBJECT_LITERAL_CONSTRUCTOR_WITH_POSITIONAL_ARGUMENTS,
2406 "Parameter '#{parameter}' in anonymous js-interop class '#{cls}' " 2406 "Some parameters in anonymous js-interop class '#{cls}' "
2407 "object literal constructor is positional instead of named." 2407 "object literal constructor are positional instead of named."
2408 ".", 2408 ".",
2409 howToFix: "Make all arguments in external factory object literal " 2409 howToFix: "Make all arguments in external factory object literal "
2410 "constructors named.", 2410 "constructors named.",
2411 examples: const [ 2411 examples: const [
2412 """ 2412 """
2413 import 'package:js/js.dart'; 2413 import 'package:js/js.dart';
2414 2414
2415 @anonymous 2415 @anonymous
2416 @JS() 2416 @JS()
2417 class Foo { 2417 class Foo {
(...skipping 1380 matching lines...) Expand 10 before | Expand all | Expand 10 after
3798 static String convertToString(value) { 3798 static String convertToString(value) {
3799 if (value is ErrorToken) { 3799 if (value is ErrorToken) {
3800 // Shouldn't happen. 3800 // Shouldn't happen.
3801 return value.assertionMessage; 3801 return value.assertionMessage;
3802 } else if (value is Token) { 3802 } else if (value is Token) {
3803 value = value.lexeme; 3803 value = value.lexeme;
3804 } 3804 }
3805 return '$value'; 3805 return '$value';
3806 } 3806 }
3807 } 3807 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend_serialization.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698