Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: pkg/compiler/lib/src/resolution/resolution_strategy.dart

Issue 2998543002: Handle js interop members in impact computation. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.resolution_strategy; 5 library dart2js.resolution_strategy;
6 6
7 import 'package:front_end/src/fasta/scanner.dart' show Token; 7 import 'package:front_end/src/fasta/scanner.dart' show Token;
8 8
9 import '../../compiler_new.dart' as api; 9 import '../../compiler_new.dart' as api;
10 import '../common.dart'; 10 import '../common.dart';
(...skipping 887 matching lines...) Expand 10 before | Expand all | Expand 10 after
898 } 898 }
899 899
900 if (fn.isFactoryConstructor && isAnonymous) { 900 if (fn.isFactoryConstructor && isAnonymous) {
901 fn.functionSignature.orderedForEachParameter((_parameter) { 901 fn.functionSignature.orderedForEachParameter((_parameter) {
902 ParameterElement parameter = _parameter; 902 ParameterElement parameter = _parameter;
903 if (!parameter.isNamed) { 903 if (!parameter.isNamed) {
904 _compiler.reporter.reportErrorMessage( 904 _compiler.reporter.reportErrorMessage(
905 parameter, 905 parameter,
906 MessageKind 906 MessageKind
907 .JS_OBJECT_LITERAL_CONSTRUCTOR_WITH_POSITIONAL_ARGUMEN TS, 907 .JS_OBJECT_LITERAL_CONSTRUCTOR_WITH_POSITIONAL_ARGUMEN TS,
908 {'parameter': parameter.name, 'cls': classElement.name}); 908 {'cls': classElement.name});
909 } 909 }
910 }); 910 });
911 } else { 911 } else {
912 checkFunctionParameters(fn); 912 checkFunctionParameters(fn);
913 } 913 }
914 } 914 }
915 }); 915 });
916 }); 916 });
917 } 917 }
918 918
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
952 952
953 @override 953 @override
954 void forEachConstructor( 954 void forEachConstructor(
955 covariant ClassElement cls, void f(ConstructorEntity constructor)) { 955 covariant ClassElement cls, void f(ConstructorEntity constructor)) {
956 cls.constructors.forEach((Element _constructor) { 956 cls.constructors.forEach((Element _constructor) {
957 ConstructorElement constructor = _constructor; 957 ConstructorElement constructor = _constructor;
958 f(constructor); 958 f(constructor);
959 }); 959 });
960 } 960 }
961 } 961 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698