Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: extensions/common/manifest.h

Issue 299853002: Make installed_loader UMA less wasteful. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/simple_feature.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest.h
diff --git a/extensions/common/manifest.h b/extensions/common/manifest.h
index a50e724c5792814e0c4c99962da0e031d1d04638..51f9938c2072aefdc3a3b65928bc323acf024a70 100644
--- a/extensions/common/manifest.h
+++ b/extensions/common/manifest.h
@@ -39,14 +39,15 @@ class Manifest {
// prefs), installed from an update URL.
EXTERNAL_POLICY_DOWNLOAD, // A crx file from an external directory (via
// admin policies), installed from an update URL.
- COMMAND_LINE, // --load-extension.
- EXTERNAL_POLICY, // A crx file from an external directory (via admin
- // policies), cached locally and installed from the
- // cache.
- EXTERNAL_COMPONENT, // Similar to COMPONENT in that it's considered an
- // internal implementation detail of chrome, but
- // installed from an update URL like the *DOWNLOAD ones.
-
+ COMMAND_LINE, // --load-extension.
+ EXTERNAL_POLICY, // A crx file from an external directory (via admin
+ // policies), cached locally and installed from the
+ // cache.
+ EXTERNAL_COMPONENT, // Similar to COMPONENT in that it's considered an
+ // internal implementation detail of chrome, but
+ // installed from an update URL like the *DOWNLOAD ones.
+
+ // New enum values must go above here.
NUM_LOCATIONS
};
@@ -62,7 +63,10 @@ class Manifest {
// backwards compatibility, we can't remove support for packaged apps
TYPE_LEGACY_PACKAGED_APP,
TYPE_PLATFORM_APP,
- TYPE_SHARED_MODULE
+ TYPE_SHARED_MODULE,
+
+ // New enum values must go above here.
+ NUM_LOAD_TYPES
};
// Given two install sources, return the one which should take priority
« no previous file with comments | « extensions/common/features/simple_feature.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698