Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2998513002: [vm] Add a stub Dart_NotifyIdle() for the embedder to suggest a good time to do GC. (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
abarth, Chinmay, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[vm] Add a stub Dart_NotifyIdle() for the embedder to suggest a good time to do GC. Issue https://github.com/flutter/flutter/issues/9594 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/6ef3f33403f0553bfbdf95bc3f27927faefff904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M runtime/include/dart_api.h View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
I note that Magenta and V8 both switched from a duration-based API to a deadline-based ...
3 years, 4 months ago (2017-08-05 00:03:53 UTC) #2
Chinmay
On 2017/08/05 at 00:03:53, rmacnak wrote: > I note that Magenta and V8 both switched ...
3 years, 4 months ago (2017-08-05 00:31:35 UTC) #3
siva
lgtm
3 years, 4 months ago (2017-08-07 16:53:04 UTC) #4
rmacnak
3 years, 4 months ago (2017-08-08 00:48:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ef3f33403f0553bfbdf95bc3f27927faefff904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698