Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2103)

Side by Side Diff: tools/gn.py

Issue 2998503002: Change defaults for build args to accommodate Flutter and Fuchsia. (Closed)
Patch Set: Change defaults for platform_sdk, use argument override for stripped dart executable Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« sdk/BUILD.gn ('K') | « sdk/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2016 The Dart project authors. All rights reserved. 2 # Copyright 2016 The Dart project authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import multiprocessing 7 import multiprocessing
8 import os 8 import os
9 import shutil 9 import shutil
10 import subprocess 10 import subprocess
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 216
217 dont_use_clang = DontUseClang(args, gn_args['target_os'], 217 dont_use_clang = DontUseClang(args, gn_args['target_os'],
218 gn_args['host_cpu'], 218 gn_args['host_cpu'],
219 gn_args['target_cpu']) 219 gn_args['target_cpu'])
220 gn_args['is_clang'] = args.clang and not dont_use_clang 220 gn_args['is_clang'] = args.clang and not dont_use_clang
221 221
222 gn_args['is_asan'] = args.asan and gn_args['is_clang'] 222 gn_args['is_asan'] = args.asan and gn_args['is_clang']
223 gn_args['is_msan'] = args.msan and gn_args['is_clang'] 223 gn_args['is_msan'] = args.msan and gn_args['is_clang']
224 gn_args['is_tsan'] = args.tsan and gn_args['is_clang'] 224 gn_args['is_tsan'] = args.tsan and gn_args['is_clang']
225 225
226 gn_args['dart_platform_sdk'] = args.platform_sdk 226 if not args.platform_sdk and not gn_args['target_cpu'].startswith('arm'):
227 gn_args['dart_platform_sdk'] = args.platform_sdk
228 gn_args['dart_stripped_binary'] = 'exe.stripped/dart'
227 229
228 # Setup the user-defined sysroot. 230 # Setup the user-defined sysroot.
229 if gn_args['target_os'] == 'linux' and args.wheezy and not crossbuild: 231 if gn_args['target_os'] == 'linux' and args.wheezy and not crossbuild:
230 gn_args['dart_use_wheezy_sysroot'] = True 232 gn_args['dart_use_wheezy_sysroot'] = True
231 else: 233 else:
232 sysroot = TargetSysroot(args) 234 sysroot = TargetSysroot(args)
233 if sysroot: 235 if sysroot:
234 gn_args['target_sysroot'] = ParseStringMap(arch, sysroot) 236 gn_args['target_sysroot'] = ParseStringMap(arch, sysroot)
235 237
236 toolchain = ToolchainPrefix(args) 238 toolchain = ToolchainPrefix(args)
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 return 1 487 return 1
486 488
487 endtime = time.time() 489 endtime = time.time()
488 if args.verbose: 490 if args.verbose:
489 print ("GN Time: %.3f seconds" % (endtime - starttime)) 491 print ("GN Time: %.3f seconds" % (endtime - starttime))
490 return 0 492 return 0
491 493
492 494
493 if __name__ == '__main__': 495 if __name__ == '__main__':
494 sys.exit(Main(sys.argv)) 496 sys.exit(Main(sys.argv))
OLDNEW
« sdk/BUILD.gn ('K') | « sdk/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698