Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2998493002: Migrate language block 45 - call_argument ... call_with. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate language block 45 - call_argument ... call_with. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/50c087d5a6f423445910f1dfda36bed7978d9b80

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into migrate-45 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -1679 lines) Patch
D tests/language/call_argument_inference_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/language/call_closurization_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/language/call_constructor_on_unresolvable_class_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/language/call_function_apply_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language/call_non_method_field_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language/call_nonexistent_constructor_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/language/call_nonexistent_static_test.dart View 1 chunk +0 lines, -102 lines 0 comments Download
D tests/language/call_operator_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/language/call_property_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/language/call_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/language/call_this_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language/call_through_getter_test.dart View 1 chunk +0 lines, -210 lines 0 comments Download
D tests/language/call_through_null_getter_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D tests/language/call_type_literal_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/language/call_with_no_such_method_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 6 chunks +36 lines, -7 lines 0 comments Download
A + tests/language_2/call_argument_inference_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/call_closurization_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A tests/language_2/call_constructor_on_unresolvable_class_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download
A + tests/language_2/call_function2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/call_function_apply_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/call_function_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/call_non_method_field_test.dart View 1 chunk +3 lines, -6 lines 0 comments Download
A tests/language_2/call_nonexistent_constructor_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download
A tests/language_2/call_nonexistent_static_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A + tests/language_2/call_operator_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/call_property_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/call_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + tests/language_2/call_this_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language_2/call_through_getter_test.dart View 4 chunks +6 lines, -32 lines 0 comments Download
A + tests/language_2/call_through_null_getter_test.dart View 5 chunks +10 lines, -15 lines 0 comments Download
A + tests/language_2/call_type_literal_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language_2/call_with_no_such_method_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/language_2/language_2_analyzer.status View 1 2 chunks +40 lines, -0 lines 0 comments Download
M tests/language_2/language_2_dart2js.status View 1 6 chunks +73 lines, -0 lines 0 comments Download
M tests/language_2/language_2_dartdevc.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language_2/language_2_flutter.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language_2/language_2_precompiled.status View 1 1 chunk +20 lines, -0 lines 0 comments Download
M tests/language_2/language_2_vm.status View 1 1 chunk +20 lines, -0 lines 0 comments Download
D tests/language_strong/call_argument_inference_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/language_strong/call_closurization_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/language_strong/call_constructor_on_unresolvable_class_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/language_strong/call_function2_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/language_strong/call_function_apply_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/language_strong/call_function_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/language_strong/call_non_method_field_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language_strong/call_nonexistent_constructor_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D tests/language_strong/call_nonexistent_static_test.dart View 1 chunk +0 lines, -102 lines 0 comments Download
D tests/language_strong/call_operator_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/language_strong/call_property_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/language_strong/call_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/language_strong/call_this_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/language_strong/call_through_getter_test.dart View 1 chunk +0 lines, -210 lines 0 comments Download
D tests/language_strong/call_through_null_getter_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D tests/language_strong/call_type_literal_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/language_strong/call_with_no_such_method_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bob Nystrom
3 years, 4 months ago (2017-08-04 22:00:23 UTC) #2
Bob Nystrom
3 years, 4 months ago (2017-08-04 23:46:28 UTC) #4
Jennifer Messerly
lgtm
3 years, 4 months ago (2017-08-05 00:02:52 UTC) #5
Bob Nystrom
3 years, 4 months ago (2017-08-05 00:15:34 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
50c087d5a6f423445910f1dfda36bed7978d9b80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698