Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: tests/language_strong/language_strong.status

Issue 2998483002: fix ddc travis bot (Closed)
Patch Set: fix comment Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/test/browser/language_tests.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language_strong/language_strong.status
diff --git a/tests/language_strong/language_strong.status b/tests/language_strong/language_strong.status
index 43a0d21fb962cc5e6e4558f8e4c7df9a247eb417..c89bb5633b23e3126a7802dda54d71f2fbc66027 100644
--- a/tests/language_strong/language_strong.status
+++ b/tests/language_strong/language_strong.status
@@ -842,4 +842,11 @@ throwing_lazy_variable_test: RuntimeError # Issue 29920
truncdiv_test: RuntimeError # Issue 29920
type_variable_nested_test: RuntimeError # Issue 29920
type_variable_typedef_test: RuntimeError # Issue 29920
-prefix10_negative_test: Fail # Issue 29920
+
+# This test does not generate the expected compile time error, but it also does
+# not behave correctly at runtime. We cannot record this as "Fail" without
+# confusing the DDC travis bot (as "Fail" is normally used for compile time
+# failures of _negative_tests). Remove "Skip" once we have the DDC travis bot
+# running on test.dart, OR when we fix dartanalyzer/dartdevc CommandOutput
+# classes to invert negative test status in the same way our other tools do.
+prefix10_negative_test: Skip # Issue 29920
« no previous file with comments | « pkg/dev_compiler/test/browser/language_tests.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698