Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 299843014: [webcrypto] Enable wrap/unwrap for SPKI and PKCS8. (Closed)

Created:
6 years, 7 months ago by eroman
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Enable wrap/unwrap for SPKI and PKCS8. (Does not yet address AES-KW, which is currently only exposed for wrapping/unwrapping of 'raw' format). BUG=373555, 245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273071

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase and address sleevi comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -55 lines) Patch
M content/child/webcrypto/shared_crypto.cc View 2 chunks +28 lines, -55 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 1 chunk +111 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eroman
6 years, 7 months ago (2014-05-23 20:32:17 UTC) #1
eroman
(For the record, the AES-KW aspect is tracked by issue 373544. This change basically just ...
6 years, 7 months ago (2014-05-23 23:26:34 UTC) #2
Ryan Sleevi
https://codereview.chromium.org/299843014/diff/1/content/child/webcrypto/shared_crypto_unittest.cc File content/child/webcrypto/shared_crypto_unittest.cc (right): https://codereview.chromium.org/299843014/diff/1/content/child/webcrypto/shared_crypto_unittest.cc#newcode3963 content/child/webcrypto/shared_crypto_unittest.cc:3963: // Generate an AES-CBC key, and an RSA key ...
6 years, 7 months ago (2014-05-24 18:18:38 UTC) #3
Ryan Sleevi
lgtm
6 years, 7 months ago (2014-05-24 18:18:43 UTC) #4
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-27 19:03:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/299843014/20001
6 years, 7 months ago (2014-05-27 19:04:35 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 23:35:55 UTC) #7
Message was sent while issue was closed.
Change committed as 273071

Powered by Google App Engine
This is Rietveld 408576698