Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 299843008: Revert 272371 "Add UMA Counts for number of IPv4 and IPv6 interf..." (Closed)

Created:
6 years, 7 months ago by Michael Courage
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272371 "Add UMA Counts for number of IPv4 and IPv6 interf..." Reason: build failure on Mac ASan 64 > Add UMA Counts for number of IPv4 and IPv6 interfaces detected for PeerConnection. > > R=sergeyu@chromium.org > BUG=N/A > > Review URL: https://codereview.chromium.org/299103002 TBR=mallinath@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M trunk/src/content/renderer/p2p/ipc_network_manager.cc View 4 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Michael Courage
6 years, 7 months ago (2014-05-23 00:23:12 UTC) #1
Michael Courage
Committed patchset #1 manually as r272379 (tree was closed).
6 years, 7 months ago (2014-05-23 00:23:18 UTC) #2
chromium-reviews
I am not sure it's failed because of my CL. From the error does't look ...
6 years, 7 months ago (2014-05-23 00:39:51 UTC) #3
chromium-reviews
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/4339 This seems like compiled fine and revert is landed after this. On Thu, May ...
6 years, 7 months ago (2014-05-23 00:45:25 UTC) #4
Michael Courage
I think that on the ASAN builders the actual error messages are sometimes obscured, and ...
6 years, 7 months ago (2014-05-23 00:47:19 UTC) #5
chromium-reviews
Is it possible to reland as I am already out of office. On Thu, May ...
6 years, 7 months ago (2014-05-23 00:48:53 UTC) #6
Michael Courage
I would, but I'd rather do it when I (or at least another sheriff) is ...
6 years, 7 months ago (2014-05-23 00:52:37 UTC) #7
Michael Courage
FYI: https://codereview.chromium.org/291343010/ Started a mac asan try run. If it looks ok I'll commit it. ...
6 years, 7 months ago (2014-05-23 17:14:46 UTC) #8
chromium-reviews
6 years, 7 months ago (2014-05-23 17:28:42 UTC) #9 
Thanks.
On May 23, 2014 10:14 AM, "Michael Courage" <courage@chromium.org> wrote:

> FYI: https://codereview.chromium.org/291343010/
> Started a mac asan try run. If it looks ok I'll commit it.
>
>
> On Thu, May 22, 2014 at 5:52 PM, Michael Courage <courage@chromium.org>wrote:
>
>> I would, but I'd rather do it when I (or at least another sheriff) is
>> around to fix problems. Apologies if your change was just the victim of a
>> build machine flake.
>>
>>
>> On Thu, May 22, 2014 at 5:48 PM, Mallinath Bareddy
<mallinath@google.com>wrote:
>>
>>> Is it possible to reland as I am already out of office.
>>>
>>>
>>> On Thu, May 22, 2014 at 5:47 PM, Michael Courage
<courage@chromium.org>wrote:
>>>
>>>> I think that on the ASAN builders the actual error messages are
>>>> sometimes obscured, and the ninja status line was building
>>>> ipc_network_manager.o. Seems reasonable to reland if the next build
worked.
>>>> I'm about to head out though.
>>>>
>>>> [4/624 | 0.000] ACTION untar_toolchains: Untar pnacl
toolchain_e3b8800e81a4bd6e0573ed62d487cccb
>>>> [5/624 | 0.000] CXX
obj/content/renderer/p2p/content_renderer.ipc_network_manager.o
>>>> FAILED: cd ../../native_client; ...
>>>>
>>>>
>>>>
>>>> On Thu, May 22, 2014 at 5:45 PM, Mallinath Bareddy <
>>>> mallinath@google.com> wrote:
>>>>
>>>>>
>>>>>
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builde...
>>>>>
>>>>> This seems like compiled fine and revert is landed after this.
>>>>>
>>>>>
>>>>> On Thu, May 22, 2014 at 5:39 PM, Mallinath Bareddy <
>>>>> mallinath@google.com> wrote:
>>>>>
>>>>>> I am not sure it's failed because of my CL. From the error does't
>>>>>> look like so.
>>>>>>
>>>>>> FAILED: cd ../../native_client; export
BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_ASan_64_Builder/build/src/out/Release;
export CONFIGURATION=Release; export PRODUCT_NAME=untar_toolchains; export
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk;
export
SRCROOT=/Volumes/data/b/build/slave/Mac_ASan_64_Builder/build/src/out/Release/../../native_client;
export SOURCE_ROOT="${SRCROOT}"; export
TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_ASan_64_Builder/build/src/out/Release;
export TEMP_DIR="${TMPDIR}";python
../native_client/build/package_version/package_version.py --quiet --packages
nacl_x86_newlib --tar-dir ../native_client/toolchain/.tars --dest-dir
../out/Release/gen/sdk extract
>>>>>> /bin/sh: line 1: 45679 Killed: 9               python
../native_client/build/package_version/package_version.py --quiet --packages
nacl_x86_newlib --tar-dir ../native_client/toolchain/.tars --dest-dir
../out/Release/gen/sdk extract
>>>>>> FAILED: cd ../../native_client; export
BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_ASan_64_Builder/build/src/out/Release;
export CONFIGURATION=Release; export PRODUCT_NAME=untar_toolchains; export
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk;
export
SRCROOT=/Volumes/data/b/build/slave/Mac_ASan_64_Builder/build/src/out/Release/../../native_client;
export SOURCE_ROOT="${SRCROOT}"; export
TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_ASan_64_Builder/build/src/out/Release;
export TEMP_DIR="${TMPDIR}";python
../native_client/build/package_version/package_version.py --quiet --packages
nacl_x86_glibc --tar-dir ../native_client/toolchain/.tars --dest-dir
../out/Release/gen/sdk extract
>>>>>> /bin/sh: line 1: 45681 Killed: 9               python
../native_client/build/package_version/package_version.py --quiet --packages
nacl_x86_glibc --tar-dir ../native_client/toolchain/.tars --dest-dir
../out/Release/gen/sdk extract
>>>>>> FAILED: cd ../../native_client; export
BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_ASan_64_Builder/build/src/out/Release;
export CONFIGURATION=Release; export PRODUCT_NAME=untar_toolchains; export
SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk;
export
SRCROOT=/Volumes/data/b/build/slave/Mac_ASan_64_Builder/build/src/out/Release/../../native_client;
export SOURCE_ROOT="${SRCROOT}"; export
TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_ASan_64_Builder/build/src/out/Release;
export TEMP_DIR="${TMPDIR}";python
../native_client/build/package_version/package_version.py --quiet --packages
pnacl_newlib --tar-dir ../native_client/toolchain/.tars --dest-dir
../out/Release/gen/sdk extract
>>>>>> /bin/sh: line 1: 45680 Killed: 9               python
../native_client/build/package_version/package_version.py --quiet --packages
pnacl_newlib --tar-dir ../native_client/toolchain/.tars --dest-dir
../out/Release/gen/sdk extract
>>>>>> ninja: build stopped: subcommand failed.
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, May 22, 2014 at 5:23 PM, <courage@chromium.org> wrote:
>>>>>>
>>>>>>> Committed patchset #1 manually as r272379 (tree was closed).
>>>>>>>
>>>>>>> https://codereview.chromium.org/299843008/
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698