Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: pkg/analyzer/lib/src/dart/analysis/driver.dart

Issue 2998423002: Clean up comments for AnalysisDriver results. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:collection'; 6 import 'dart:collection';
7 import 'dart:typed_data'; 7 import 'dart:typed_data';
8 8
9 import 'package:analyzer/context/context_root.dart'; 9 import 'package:analyzer/context/context_root.dart';
10 import 'package:analyzer/context/declared_variables.dart'; 10 import 'package:analyzer/context/declared_variables.dart';
(...skipping 1679 matching lines...) Expand 10 before | Expand all | Expand 10 after
1690 return libraryContext.store; 1690 return libraryContext.store;
1691 } finally { 1691 } finally {
1692 libraryContext.dispose(); 1692 libraryContext.dispose();
1693 } 1693 }
1694 } 1694 }
1695 } 1695 }
1696 1696
1697 /** 1697 /**
1698 * The result of analyzing of a single file. 1698 * The result of analyzing of a single file.
1699 * 1699 *
1700 * These results are self-consistent, i.e. [content], [contentHash], the 1700 * These results are self-consistent, i.e. [content], [lineInfo], the
1701 * resolved [unit] correspond to each other. All referenced elements, even 1701 * resolved [unit] correspond to each other. All referenced elements, even
1702 * external ones, are also self-consistent. But none of the results is 1702 * external ones, are also self-consistent. But none of the results is
1703 * guaranteed to be consistent with the state of the files. 1703 * guaranteed to be consistent with the state of the files.
1704 * 1704 *
1705 * Every result is independent, and is not guaranteed to be consistent with 1705 * Every result is independent, and is not guaranteed to be consistent with
1706 * any previously returned result, even inside of the same library. 1706 * any previously returned result, even inside of the same library.
1707 */ 1707 */
1708 class AnalysisResult extends BaseAnalysisResult 1708 class AnalysisResult extends BaseAnalysisResult
1709 implements results.ResolveResult { 1709 implements results.ResolveResult {
1710 static final _UNCHANGED = new AnalysisResult( 1710 static final _UNCHANGED = new AnalysisResult(
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
1808 1808
1809 /** 1809 /**
1810 * The context manager has just removed the given analysis [driver]. 1810 * The context manager has just removed the given analysis [driver].
1811 */ 1811 */
1812 void removedDriver(AnalysisDriver driver); 1812 void removedDriver(AnalysisDriver driver);
1813 } 1813 }
1814 1814
1815 /** 1815 /**
1816 * The errors in a single file. 1816 * The errors in a single file.
1817 * 1817 *
1818 * These results are self-consistent, i.e. [content], [contentHash], [errors] 1818 * These results are self-consistent, i.e. [errors] and [lineInfo] correspond
1819 * correspond to each other. But none of the results is guaranteed to be 1819 * to each other. But none of the results is guaranteed to be consistent with
1820 * consistent with the state of the files. 1820 * the state of the files.
1821 */ 1821 */
1822 class ErrorsResult extends BaseAnalysisResult implements results.ErrorsResult { 1822 class ErrorsResult extends BaseAnalysisResult implements results.ErrorsResult {
1823 @override 1823 @override
1824 final LineInfo lineInfo; 1824 final LineInfo lineInfo;
1825 1825
1826 @override 1826 @override
1827 final List<AnalysisError> errors; 1827 final List<AnalysisError> errors;
1828 1828
1829 ErrorsResult( 1829 ErrorsResult(
1830 AnalysisSession session, String path, Uri uri, this.lineInfo, this.errors) 1830 AnalysisSession session, String path, Uri uri, this.lineInfo, this.errors)
(...skipping 26 matching lines...) Expand all
1857 * number of context to store was reached, etc. 1857 * number of context to store was reached, etc.
1858 */ 1858 */
1859 final String contextKey; 1859 final String contextKey;
1860 1860
1861 ExceptionResult(this.path, this.exception, this.contextKey); 1861 ExceptionResult(this.path, this.exception, this.contextKey);
1862 } 1862 }
1863 1863
1864 /** 1864 /**
1865 * The result of parsing of a single file. 1865 * The result of parsing of a single file.
1866 * 1866 *
1867 * These results are self-consistent, i.e. [content], [contentHash], the 1867 * These results are self-consistent, i.e. [content], [lineInfo], the
1868 * resolved [unit] correspond to each other. But none of the results is 1868 * parsed [unit] correspond to each other. But none of the results is
1869 * guaranteed to be consistent with the state of the files. 1869 * guaranteed to be consistent with the state of the files.
1870 */ 1870 */
1871 class ParseResult extends BaseAnalysisResult implements results.ParseResult { 1871 class ParseResult extends BaseAnalysisResult implements results.ParseResult {
1872 @override 1872 @override
1873 final String content; 1873 final String content;
1874 1874
1875 @override 1875 @override
1876 final LineInfo lineInfo; 1876 final LineInfo lineInfo;
1877 1877
1878 @override 1878 @override
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
2107 libraryDeclarations.add(new TopLevelDeclarationInSource( 2107 libraryDeclarations.add(new TopLevelDeclarationInSource(
2108 file.source, declaration, isExported)); 2108 file.source, declaration, isExported));
2109 } 2109 }
2110 } 2110 }
2111 } 2111 }
2112 2112
2113 // We're not done yet. 2113 // We're not done yet.
2114 return false; 2114 return false;
2115 } 2115 }
2116 } 2116 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698