Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2998413002: dart2js kernel: update tryInlineNativeMethod to Entities (Closed)

Created:
3 years, 3 months ago by sra1
Modified:
3 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js kernel: update tryInlineNativeMethod to Entities R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/5865a13c44b7f4b93d84c9d05382c0189d5d27b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -45 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 4 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 4 chunks +4 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/rasta_ssa_builder_task.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 5 chunks +10 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
3 years, 3 months ago (2017-08-25 19:20:52 UTC) #3
Emily Fortuna
lgtm. awesome!
3 years, 3 months ago (2017-08-25 19:23:16 UTC) #4
sra1
3 years, 3 months ago (2017-08-25 23:13:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
5865a13c44b7f4b93d84c9d05382c0189d5d27b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698