Issue 2998373002: [dart:io] Move _getUriBaseClosure to dart:io

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2998373002: [dart:io] Move _getUriBaseClosure to dart:io (Closed)

Created:
3 years, 3 months ago by zra

Modified:
3 years, 3 months ago

Reviewers:
rmacnak, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[dart:io] Move _getUriBaseClosure to dart:io In a forthcoming change, this will allow Uri.base to be aware of the isolate's current namespace. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/130f3be2971e7981dcae12895b09107e68dbc029

Created: 3 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -33 lines)			Patch
M	runtime/bin/builtin.dart	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	runtime/bin/builtin_natives.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/bin/dartutils.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/dartutils.cc	View	3 chunks	+3 lines, -14 lines	0 comments	Download
M	runtime/bin/directory_patch.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/bin/main.cc	View	2 chunks	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

zra

3 years, 3 months ago (2017-08-25 03:06:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
130f3be2971e7981dcae12895b09107e68dbc029 (presubmit successful).