Issue 2998363002: Generalize LRU Cache to any objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2998363002: Generalize LRU Cache to any objects. (Closed)

Created:
3 years, 4 months ago by scheglov

Modified:
3 years, 4 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Generalize LRU Cache to any objects. It turned out that caching just bytes does not allow us to realize full benefits of caching PackageBundle(s). We want to keep partially decoded values like sub-objects and strings for maximum performance. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6d5a29004cc44db2f79a4d6e34769bd510e69c16

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -134 lines)			Patch
M	pkg/front_end/lib/src/byte_store/byte_store.dart	View	2 chunks	+3 lines, -52 lines	0 comments	Download
A	pkg/front_end/lib/src/byte_store/cache.dart	View	1 chunk	+58 lines, -0 lines	0 comments	Download
M	pkg/front_end/test/src/byte_store/byte_store_test.dart	View	2 chunks	+0 lines, -82 lines	0 comments	Download
A	pkg/front_end/test/src/byte_store/cache_test.dart	View	1 chunk	+101 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 4 months ago (2017-08-24 18:07:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6d5a29004cc44db2f79a4d6e34769bd510e69c16 (presubmit successful).