Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Side by Side Diff: mojo/public/cpp/bindings/message.h

Issue 299833008: Move AcceptWithResponder() out of the MessageReceiver interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « mojo/public/cpp/bindings/lib/router.cc ('k') | mojo/public/cpp/bindings/message_filter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_ 5 #ifndef MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_
6 #define MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_ 6 #define MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_
7 7
8 #include <assert.h> 8 #include <assert.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 }; 77 };
78 78
79 class MessageReceiver { 79 class MessageReceiver {
80 public: 80 public:
81 virtual ~MessageReceiver() {} 81 virtual ~MessageReceiver() {}
82 82
83 // The receiver may mutate the given message. Returns true if the message 83 // The receiver may mutate the given message. Returns true if the message
84 // was accepted and false otherwise, indicating that the message was invalid 84 // was accepted and false otherwise, indicating that the message was invalid
85 // or malformed. 85 // or malformed.
86 virtual bool Accept(Message* message) MOJO_WARN_UNUSED_RESULT = 0; 86 virtual bool Accept(Message* message) MOJO_WARN_UNUSED_RESULT = 0;
87 };
88
89 class MessageReceiverWithResponder : public MessageReceiver {
90 public:
91 virtual ~MessageReceiverWithResponder() {}
87 92
88 // A variant on Accept that registers a MessageReceiver (known as the 93 // A variant on Accept that registers a MessageReceiver (known as the
89 // responder) to handle the response message generated from the given 94 // responder) to handle the response message generated from the given
90 // message. The responder's Accept method may be called during 95 // message. The responder's Accept method may be called during
91 // AcceptWithResponder or some time after its return. 96 // AcceptWithResponder or some time after its return.
92 // 97 //
93 // NOTE: Upon returning true, AcceptWithResponder assumes ownership of 98 // NOTE: Upon returning true, AcceptWithResponder assumes ownership of
94 // |responder| and will delete it after calling |responder->Accept| or upon 99 // |responder| and will delete it after calling |responder->Accept| or upon
95 // its own destruction. 100 // its own destruction.
96 // 101 //
97 virtual bool AcceptWithResponder( 102 virtual bool AcceptWithResponder(
98 Message* message, MessageReceiver* responder) MOJO_WARN_UNUSED_RESULT = 0; 103 Message* message, MessageReceiver* responder) MOJO_WARN_UNUSED_RESULT = 0;
99 }; 104 };
100 105
101 // Read a single message from the pipe and dispatch to the given receiver. The 106 // Read a single message from the pipe and dispatch to the given receiver. The
102 // receiver may be null, in which case the message is simply discarded. 107 // receiver may be null, in which case the message is simply discarded.
103 // Returns MOJO_RESULT_SHOULD_WAIT if the caller should wait on the handle to 108 // Returns MOJO_RESULT_SHOULD_WAIT if the caller should wait on the handle to
104 // become readable. Returns MOJO_RESULT_OK if a message was dispatched and 109 // become readable. Returns MOJO_RESULT_OK if a message was dispatched and
105 // otherwise returns an error code if something went wrong. 110 // otherwise returns an error code if something went wrong.
106 // 111 //
107 // NOTE: The message hasn't been validated and may be malformed! 112 // NOTE: The message hasn't been validated and may be malformed!
108 MojoResult ReadAndDispatchMessage(MessagePipeHandle handle, 113 MojoResult ReadAndDispatchMessage(MessagePipeHandle handle,
109 MessageReceiver* receiver, 114 MessageReceiver* receiver,
110 bool* receiver_result); 115 bool* receiver_result);
111 116
112 } // namespace mojo 117 } // namespace mojo
113 118
114 #endif // MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_ 119 #endif // MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_
OLDNEW
« no previous file with comments | « mojo/public/cpp/bindings/lib/router.cc ('k') | mojo/public/cpp/bindings/message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698